chrome/browser/download/notification/download_notification_item.h - Issue 1105953002: Pop up the notification when the download is interrupted or completed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_notification_item.h

Issue 1105953002: Pop up the notification when the download is interrupted or completed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dn-xxxx-close-bug

Patch Set: Adressed comment and pop up the notification after completion Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/notification/download_notification_browsertest.cc ('k') | chrome/browser/download/notification/download_notification_item.cc » ('j') | chrome/browser/download/notification/download_notification_item.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/notification/download_notification_item.h

diff --git a/chrome/browser/download/notification/download_notification_item.h b/chrome/browser/download/notification/download_notification_item.h

index ab51542f7b6cffdaeb3bbd95b43fa231e1436f82..3c4d4353d6b6cfe000f3f0a45951dba0f7809d71 100644

--- a/chrome/browser/download/notification/download_notification_item.h

+++ b/chrome/browser/download/notification/download_notification_item.h

@@ -84,6 +84,7 @@ class DownloadNotificationItem : public content::DownloadItem::Observer {

void OnDownloadDestroyed(content::DownloadItem* item) override;

void CloseNotificationByUser();

+ void CloseNotificationByNonUser();

void UpdateNotificationData(NotificationUpdateType type);

void SetNotificationImage(int resource_id);

@@ -102,7 +103,8 @@ class DownloadNotificationItem : public content::DownloadItem::Observer {

scoped_ptr<std::vector<DownloadCommands::Command>> GetPossibleActions() const;

bool openable_;

- bool downloading_;

+ content::DownloadItem::DownloadState previous_download_state_ =

+ content::DownloadItem::MAX_DOWNLOAD_STATE; // As uninitialized state

int image_resource_id_;

Profile* profile_;

scoped_refptr<NotificationWatcher> watcher_;