Pop up the notification when the download is interrupted or completed

chrome/browser/download/notification/download_notification_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
@@ skipping 343 matching lines @@
 IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DownloadFile) {
   CreateDownload();
 
   EXPECT_EQ(l10n_util::GetStringFUTF16(
                 IDS_DOWNLOAD_STATUS_IN_PROGRESS_TITLE,
                 download_item()->GetFileNameToReportUser().LossyDisplayName()),
             GetNotification(notification_id())->title());
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_PROGRESS,
             GetNotification(notification_id())->type());
 
+  // Installs observers before requesting the completion.
+  NotificationAddObserver download_notification_add_observer;
+  NotificationRemoveObserver download_notification_remove_observer;
+
   // Requests to complete the download.
   ui_test_utils::NavigateToURL(
       browser(), GURL(net::URLRequestSlowDownloadJob::kFinishDownloadUrl));
 
   // Waits for download completion.
   while (download_item()->GetState() != content::DownloadItem::COMPLETE) {
     NotificationUpdateObserver download_change_notification_observer;
     download_change_notification_observer.Wait();
   }
 
+  // Waits for new notification.
+  download_notification_remove_observer.Wait();
+  download_notification_add_observer.Wait();
+
+  // Checks strings.
   EXPECT_EQ(l10n_util::GetStringFUTF16(
                 IDS_DOWNLOAD_STATUS_DOWNLOADED_TITLE,
                 download_item()->GetFileNameToReportUser().LossyDisplayName()),
             GetNotification(notification_id())->title());
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
             GetNotification(notification_id())->type());
 
+  // Confirms that there is only one notification.
+  message_center::NotificationList::Notifications
+      visible_notifications = GetMessageCenter()->GetVisibleNotifications();
+  EXPECT_EQ(1u, visible_notifications.size());
+  EXPECT_TRUE(IsInNotifications(visible_notifications, notification_id()));
+
   // Opens the message center.
   GetMessageCenter()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);
 
   // Try to open the downloaded item by clicking the notification.
   EXPECT_FALSE(GetDownloadManagerDelegate()->opened());
   GetMessageCenter()->ClickOnNotification(notification_id());
   EXPECT_TRUE(GetDownloadManagerDelegate()->opened());
 
   EXPECT_FALSE(GetNotification(notification_id()));
 }
@@ skipping 132 matching lines @@
 
   // Closes the notification.
   NotificationRemoveObserver notification_close_observer;
   GetMessageCenter()->RemoveNotification(notification_id(), true /* by_user */);
   EXPECT_EQ(notification_id(), notification_close_observer.Wait());
 
   EXPECT_EQ(0u, GetMessageCenter()->GetVisibleNotifications().size());
 
   // Confirms that a download is still in progress.
   std::vector<content::DownloadItem*> downloads;
-  GetDownloadManager(browser())->GetAllDownloads(&downloads);
+  content::DownloadManager* download_manager = GetDownloadManager(browser());
+  download_manager->GetAllDownloads(&downloads);
   EXPECT_EQ(1u, downloads.size());
   EXPECT_EQ(content::DownloadItem::IN_PROGRESS, downloads[0]->GetState());
 
-  // Cleans the downloading.
-  downloads[0]->Cancel(true);
+  // Installs observers before requesting the completion.
+  NotificationAddObserver download_notification_add_observer;
+  content::DownloadTestObserverTerminal download_terminal_observer(
+      download_manager,
+      1u, /* wait_count */
+      content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
+
+  // Requests to complete the download and wait for it.
+  ui_test_utils::NavigateToURL(
+      browser(), GURL(net::URLRequestSlowDownloadJob::kFinishDownloadUrl));
+  download_terminal_observer.WaitForFinished();
+
+  // Waits that new notification.
+  download_notification_add_observer.Wait();
+
+  // Confirms that there is only one notification.
+  message_center::NotificationList::Notifications
+      visible_notifications = GetMessageCenter()->GetVisibleNotifications();
+  EXPECT_EQ(1u, visible_notifications.size());
+  EXPECT_TRUE(IsInNotifications(visible_notifications, notification_id()));
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, InterruptDownload) {
+  CreateDownload();
+
+  // Installs observers before requesting.
+  NotificationAddObserver download_notification_add_observer;
+  NotificationRemoveObserver download_notification_remove_observer;
+  content::DownloadTestObserverTerminal download_terminal_observer(
+      GetDownloadManager(browser()),
+      1u, /* wait_count */
+      content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
+
+  // Requests to fail the download and wait for it.
+  ui_test_utils::NavigateToURL(
+      browser(), GURL(net::URLRequestSlowDownloadJob::kErrorDownloadUrl));
+  download_terminal_observer.WaitForFinished();
+
+  // Waits that new notification.
+  download_notification_remove_observer.Wait();
+  download_notification_add_observer.Wait();
+
+  // Confirms that there is only one notification.
+  message_center::NotificationList::Notifications
+      visible_notifications = GetMessageCenter()->GetVisibleNotifications();
+  EXPECT_EQ(1u, visible_notifications.size());
+  EXPECT_TRUE(IsInNotifications(visible_notifications, notification_id()));
+
+  // Checks strings.
+  EXPECT_EQ(l10n_util::GetStringFUTF16(
+                IDS_DOWNLOAD_STATUS_DOWNLOAD_FAILED_TITLE,
+                download_item()->GetFileNameToReportUser().LossyDisplayName()),
+            GetNotification(notification_id())->title());
+  EXPECT_EQ(l10n_util::GetStringFUTF16(
+                IDS_DOWNLOAD_STATUS_INTERRUPTED,
+                l10n_util::GetStringUTF16(
+                    IDS_DOWNLOAD_INTERRUPTED_STATUS_NETWORK_ERROR)),
+            GetNotification(notification_id())->message());
+  EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
+            GetNotification(notification_id())->type());
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
+                       InterruptDownloadAfterClosingNotification) {
+  CreateDownload();
+
+  // Closes the notification.
+  NotificationRemoveObserver notification_close_observer;
+  GetMessageCenter()->RemoveNotification(notification_id(), true /* by_user */);
+  EXPECT_EQ(notification_id(), notification_close_observer.Wait());
+
+  EXPECT_EQ(0u, GetMessageCenter()->GetVisibleNotifications().size());
+
+  // Confirms that a download is still in progress.
+  std::vector<content::DownloadItem*> downloads;
+  content::DownloadManager* download_manager = GetDownloadManager(browser());
+  download_manager->GetAllDownloads(&downloads);
+  EXPECT_EQ(1u, downloads.size());
+  EXPECT_EQ(content::DownloadItem::IN_PROGRESS, downloads[0]->GetState());
+
+  // Installs observers before requesting the completion.
+  NotificationAddObserver download_notification_add_observer;
+  content::DownloadTestObserverTerminal download_terminal_observer(
+      download_manager,
+      1u, /* wait_count */
+      content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
+
+  // Requests to fail the download and wait for it.
+  ui_test_utils::NavigateToURL(
+      browser(), GURL(net::URLRequestSlowDownloadJob::kErrorDownloadUrl));
+  download_terminal_observer.WaitForFinished();
+
+  // Waits that new notification.
+  download_notification_add_observer.Wait();
+
+  // Confirms that there is only one notification.
+  message_center::NotificationList::Notifications
+      visible_notifications = GetMessageCenter()->GetVisibleNotifications();
+  EXPECT_EQ(1u, visible_notifications.size());
+  EXPECT_TRUE(IsInNotifications(visible_notifications, notification_id()));
 }
 
 IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DownloadRemoved) {
   CreateDownload();
 
   NotificationRemoveObserver notification_close_observer;
   download_item()->Remove();
   EXPECT_EQ(notification_id(), notification_close_observer.Wait());
 
   // Confirms that the notification is removed.
@@ skipping 381 matching lines @@
   }
 
   // Confirms the types of download notifications are correct.
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
             GetNotification(notification_id1)->type());
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
             GetNotification(notification_id2)->type());
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
             GetNotification(notification_id3)->type());
 }