Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1105943002: fix multiple intersection logic (Closed)

Created:
5 years, 8 months ago by caryclark
Modified:
5 years, 8 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix multiple intersection logic When three or more curves intersect at the same point, ensure that each curve records the intersections of the others. This fixes a number of cubic tests. TBR=reed@google.com BUG=skia:3588 Committed: https://skia.googlesource.com/skia/+/08bc8488fa2ea2d2a17efb1443f0ec6579d5a3c8

Patch Set 1 #

Patch Set 2 : fix linux #

Patch Set 3 : fix valgrind #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/pathops/SkPathOpsOp.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105943002/1
5 years, 8 months ago (2015-04-24 15:55:20 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/493) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
5 years, 8 months ago (2015-04-24 16:01:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105943002/20001
5 years, 8 months ago (2015-04-24 16:02:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-24 16:07:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105943002/20001
5 years, 8 months ago (2015-04-24 16:08:39 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 16:09:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/08bc8488fa2ea2d2a17efb1443f0ec6579d5a3c8

Powered by Google App Engine
This is Rietveld 408576698