Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1105913002: fix for using too much memory in GrBatchAtlas (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix for using too much memory in GrBatchAtlas BUG=skia: Committed: https://skia.googlesource.com/skia/+/e062db9cc6478745138cca964ee46839e413ab7b

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M src/gpu/GrBatchAtlas.cpp View 1 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal, this is the simple way to do this. I could also reduce the number ...
5 years, 8 months ago (2015-04-24 14:45:53 UTC) #2
bsalomon
https://codereview.chromium.org/1105913002/diff/1/src/gpu/GrBatchAtlas.cpp File src/gpu/GrBatchAtlas.cpp (right): https://codereview.chromium.org/1105913002/diff/1/src/gpu/GrBatchAtlas.cpp#newcode54 src/gpu/GrBatchAtlas.cpp:54: fData = reinterpret_cast<unsigned char*>(sk_calloc_throw(fBytesPerPixel * fWidth * fHeight)); lgtm, ...
5 years, 8 months ago (2015-04-24 15:07:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105913002/20001
5 years, 8 months ago (2015-04-24 15:27:52 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 15:33:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e062db9cc6478745138cca964ee46839e413ab7b

Powered by Google App Engine
This is Rietveld 408576698