Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1105863003: Revert of Implementing a BLE connection finder. (Closed)

Created:
5 years, 8 months ago by Justin Donnelly
Modified:
5 years, 8 months ago
Reviewers:
sacomoto, Tim Song, msarda
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implementing a BLE connection finder. (patchset #6 id:100001 of https://codereview.chromium.org/1094273003/) Reason for revert: This change broke the chromium perf dashboard: https://build.chromium.org/p/chromium/builders/Linux/builds/61221 by adding a new static initializer: const std::string kSmartLockServiceUUID = "b3b7e28e-a000-3e17-bd86-6e97b9e28c11"; I think you want static const char* instead. Original issue's description: > Implementing a BLE connection finder. > > This CL adds a connection finder class. The connection finder scans for > Bluetooth Low Energy devices advertising a given target service. > > The current version only works when the remote device advertising the > target service is sending all its primary services UUID. > > BUG=479673 > R=msarda > TBR=tengs > > Committed: https://crrev.com/f56835d5211fc533a02f143e06eb310764f6b901 > Cr-Commit-Position: refs/heads/master@{#326807} TBR=msarda@chromium.org,tengs@chromium.org,sacomoto@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=479673 Committed: https://crrev.com/79289369bee811b37d810710fbcfe44a822d525c Cr-Commit-Position: refs/heads/master@{#326826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -310 lines) Patch
M components/proximity_auth.gypi View 2 chunks +2 lines, -4 lines 0 comments Download
M components/proximity_auth/ble/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h View 1 chunk +0 lines, -106 lines 0 comments Download
D components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc View 1 chunk +0 lines, -180 lines 0 comments Download
M components/proximity_auth/ble/proximity_auth_ble_system.cc View 1 chunk +1 line, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Donnelly
Created Revert of Implementing a BLE connection finder.
5 years, 8 months ago (2015-04-24 17:23:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105863003/1
5 years, 8 months ago (2015-04-24 17:24:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 17:25:22 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 17:26:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79289369bee811b37d810710fbcfe44a822d525c
Cr-Commit-Position: refs/heads/master@{#326826}

Powered by Google App Engine
This is Rietveld 408576698