Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1105843002: Stop deleting ShortcutsDatabase on the UI thread during shutdown (Closed)

Created:
5 years, 8 months ago by hashimoto
Modified:
5 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop deleting ShortcutsDatabase on the UI thread during shutdown Deleting ShortcutsDatabase on the UI thread results in destructing sql::Connection. This results in disk IO and slows down shutdown. BUG=480822 Committed: https://crrev.com/e69fa8e831ec653b287781126ac0a12cbcb8c78c Cr-Commit-Position: refs/heads/master@{#327231}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix leak in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/autocomplete/shortcuts_backend.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hashimoto
5 years, 8 months ago (2015-04-27 08:08:44 UTC) #4
Peter Kasting
LGTM
5 years, 8 months ago (2015-04-27 20:13:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105843002/80001
5 years, 7 months ago (2015-04-28 03:37:41 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 7 months ago (2015-04-28 04:42:35 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 04:43:27 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e69fa8e831ec653b287781126ac0a12cbcb8c78c
Cr-Commit-Position: refs/heads/master@{#327231}

Powered by Google App Engine
This is Rietveld 408576698