Add a 0.8 version of cr-checkbox with a demo

Add a 0.8 version of cr-checkbox with a demo

BUG=480762
Committed: https://crrev.com/70d5d306dae62efe88b002ac716b8bdd8f3a7ba7
Cr-Commit-Position: refs/heads/master@{#327349}

[Jeremy Klein, 2015-04-24 03:13:16]

jlklein@chromium.org changed reviewers:
+ jhawkins@google.com, michaelpg@chromium.org

[Jeremy Klein, 2015-04-24 03:13:17]

This is diffbased on https://codereview.chromium.org/1082403004/

https://codereview.chromium.org/1105743003/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements_resources.grdp (right):

https://codereview.chromium.org/1105743003/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements_resources.grdp:101: <structure
name="IDR_CR_ELEMENTS_08_CR_CHECKBOX_DEMO"
I can get rid of this if you'd like. It was useful for testing, but doesn't need
to be served all the time.

[Jeremy Klein, 2015-04-24 03:27:42]

https://codereview.chromium.org/1105743003/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v0_8/cr_checkbox/cr_checkbox.js (left):

https://codereview.chromium.org/1105743003/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v0_8/cr_checkbox/cr_checkbox.js:54:
this.$.events.forward(this.$.checkbox, ['change']);
Got rid of this because it's never actually fired at the moment. I also sent
out:

https://github.com/PolymerElements/paper-checkbox/pull/6

to fix that. I'll add a 0.8 cr-events in another CL.

[James Hawkins, 2015-04-24 16:55:32]

jhawkins@chromium.org changed reviewers:
+ jhawkins@chromium.org

[James Hawkins, 2015-04-24 16:55:33]

My gut instinct is that it's pretty terrible that we're having to introduce
versioning in our code.

[Jeremy Klein, 2015-04-24 17:01:32]

On 2015/04/24 16:55:33, James Hawkins wrote:
> My gut instinct is that it's pretty terrible that we're having to introduce
> versioning in our code.

I agree, but I'm not sure I see an alternative. I think the cost of doing one
giant switching CL for *all* of our code will just be too high when switching to
0.8. Do you see an alternative I'm missing?

[Jeremy Klein, 2015-04-24 17:01:33]

On 2015/04/24 16:55:33, James Hawkins wrote:
> My gut instinct is that it's pretty terrible that we're having to introduce
> versioning in our code.

I agree, but I'm not sure I see an alternative. I think the cost of doing one
giant switching CL for *all* of our code will just be too high when switching to
0.8. Do you see an alternative I'm missing?

[michaelpg, 2015-04-26 01:02:39]

On 2015/04/24 17:01:33, Jeremy Klein wrote:
> On 2015/04/24 16:55:33, James Hawkins wrote:
> > My gut instinct is that it's pretty terrible that we're having to introduce
> > versioning in our code.
> 
> I agree, but I'm not sure I see an alternative. I think the cost of doing one
> giant switching CL for *all* of our code will just be too high when switching
to
> 0.8. Do you see an alternative I'm missing?

I don't think it's too bad. I wouldn't want to maintain two copies of the whole
app. But if it's just some smaller components, we won't have a lot of
dependencies to worry about. Once we upgrade the pages and skeleton to 0.8, we
should just have to do a sed and git mv and nothing more.

[michaelpg, 2015-04-27 05:11:01]

https://codereview.chromium.org/1105743003/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/v0_8/cr_checkbox/cr_checkbox.html (right):

https://codereview.chromium.org/1105743003/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/v0_8/cr_checkbox/cr_checkbox.html:6: <link
rel="import" type="css" href="cr_checkbox.css">
This should be outside the <template>, does it work this way too?

https://www.polymer-project.org/0.8/docs/devguide/experimental.html#external-...

[Jeremy Klein, 2015-04-28 00:11:58]

https://codereview.chromium.org/1105743003/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/v0_8/cr_checkbox/cr_checkbox.html (right):

https://codereview.chromium.org/1105743003/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/v0_8/cr_checkbox/cr_checkbox.html:6: <link
rel="import" type="css" href="cr_checkbox.css">
On 2015/04/27 05:11:01, michaelpg wrote:
> This should be outside the <template>, does it work this way too?
> 
>
https://www.polymer-project.org/0.8/docs/devguide/experimental.html#external-...

Good catch. It does seem to work this way for some reason, but it should
definitely be outside the template. Done.

[michaelpg, 2015-04-28 04:04:01]

lgtm

https://codereview.chromium.org/1105743003/diff/60001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements_resources.grdp (right):

https://codereview.chromium.org/1105743003/diff/60001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements_resources.grdp:101: <structure
name="IDR_CR_ELEMENTS_08_CR_CHECKBOX_DEMO"
is it necessary to build the demo?

[Jeremy Klein, 2015-04-28 04:18:20]

https://codereview.chromium.org/1105743003/diff/60001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements_resources.grdp (right):

https://codereview.chromium.org/1105743003/diff/60001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements_resources.grdp:101: <structure
name="IDR_CR_ELEMENTS_08_CR_CHECKBOX_DEMO"
On 2015/04/28 04:04:00, michaelpg wrote:
> is it necessary to build the demo?

Was just using for testing. Removed.

[Jeremy Klein, 2015-04-28 04:18:28]

The CQ bit was checked by jlklein@chromium.org

[Jeremy Klein, 2015-04-28 04:18:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1105743003/#ps80001
(title: "Remove the demo structure from cr_elements_resources.grdp"")

[commit-bot: I haz the power, 2015-04-28 04:18:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1105743003/80001

[commit-bot: I haz the power, 2015-04-28 04:24:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 04:24:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jeremy Klein, 2015-04-28 04:36:50]

Forgot I still need an LG from jhawkins@ for shared_resources_data_source.cc.
James, are you cool with the proposal at http://goo.gl/dfwbi6? The cr-elements
will be converted with the parallel v0_8 directory, but the rest of the app will
be done in-place. This will just allow us to make progress on the conversion
while we wait for the last few paper-elements to be upgraded to 0.8.

[James Hawkins, 2015-04-28 17:36:42]

lgtm

[Jeremy Klein, 2015-04-28 18:30:11]

The CQ bit was checked by jlklein@chromium.org

[commit-bot: I haz the power, 2015-04-28 18:30:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1105743003/80001

[James Hawkins, 2015-04-28 18:42:56]

jhawkins@chromium.org changed reviewers:
- jhawkins@google.com

[Jeremy Klein, 2015-04-28 18:48:10]

The CQ bit was unchecked by jlklein@chromium.org

[Jeremy Klein, 2015-04-28 18:48:13]

The CQ bit was checked by jlklein@chromium.org

[commit-bot: I haz the power, 2015-04-28 18:50:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1105743003/80001

[commit-bot: I haz the power, 2015-04-28 19:39:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-28 19:41:40]

Patchset 5 (id:??) landed as
https://crrev.com/70d5d306dae62efe88b002ac716b8bdd8f3a7ba7
Cr-Commit-Position: refs/heads/master@{#327349}