| Index: src/ia32/ic-ia32.cc
|
| diff --git a/src/ia32/ic-ia32.cc b/src/ia32/ic-ia32.cc
|
| index 0b7c4a828bce881c03ed05d44cfbf3943e103164..53742dc8913dcb3bc37842bd4b7389fa4e311802 100644
|
| --- a/src/ia32/ic-ia32.cc
|
| +++ b/src/ia32/ic-ia32.cc
|
| @@ -611,7 +611,7 @@ void KeyedLoadIC::GenerateString(MacroAssembler* masm) {
|
| char_at_generator.GenerateSlow(masm, call_helper);
|
|
|
| __ bind(&miss);
|
| - GenerateMiss(masm, MISS);
|
| + GenerateMiss(masm);
|
| }
|
|
|
|
|
| @@ -653,7 +653,7 @@ void KeyedLoadIC::GenerateIndexedInterceptor(MacroAssembler* masm) {
|
| __ TailCallExternalReference(ref, 2, 1);
|
|
|
| __ bind(&slow);
|
| - GenerateMiss(masm, MISS);
|
| + GenerateMiss(masm);
|
| }
|
|
|
|
|
| @@ -678,7 +678,7 @@ void KeyedLoadIC::GenerateNonStrictArguments(MacroAssembler* masm) {
|
| __ mov(eax, unmapped_location);
|
| __ Ret();
|
| __ bind(&slow);
|
| - GenerateMiss(masm, MISS);
|
| + GenerateMiss(masm);
|
| }
|
|
|
|
|
| @@ -707,7 +707,7 @@ void KeyedStoreIC::GenerateNonStrictArguments(MacroAssembler* masm) {
|
| __ RecordWrite(ebx, edi, edx, kDontSaveFPRegs);
|
| __ Ret();
|
| __ bind(&slow);
|
| - GenerateMiss(masm, MISS);
|
| + GenerateMiss(masm);
|
| }
|
|
|
|
|
| @@ -874,10 +874,10 @@ void KeyedStoreIC::GenerateGeneric(MacroAssembler* masm,
|
| __ JumpIfSmi(edx, &slow);
|
| // Get the map from the receiver.
|
| __ mov(edi, FieldOperand(edx, HeapObject::kMapOffset));
|
| - // Check that the receiver does not require access checks. We need
|
| - // to do this because this generic stub does not perform map checks.
|
| + // Check that the receiver does not require access checks and is not observed.
|
| + // The generic stub does not perform map checks or handle observed objects.
|
| __ test_b(FieldOperand(edi, Map::kBitFieldOffset),
|
| - 1 << Map::kIsAccessCheckNeeded);
|
| + 1 << Map::kIsAccessCheckNeeded | 1 << Map::kIsObserved);
|
| __ j(not_zero, &slow);
|
| // Check that the key is a smi.
|
| __ JumpIfNotSmi(ecx, &slow);
|
| @@ -1396,7 +1396,7 @@ void LoadIC::GenerateRuntimeGetProperty(MacroAssembler* masm) {
|
| }
|
|
|
|
|
| -void KeyedLoadIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) {
|
| +void KeyedLoadIC::GenerateMiss(MacroAssembler* masm) {
|
| // ----------- S t a t e -------------
|
| // -- ecx : key
|
| // -- edx : receiver
|
| @@ -1411,10 +1411,8 @@ void KeyedLoadIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) {
|
| __ push(ebx); // return address
|
|
|
| // Perform tail call to the entry.
|
| - ExternalReference ref = miss_mode == MISS_FORCE_GENERIC
|
| - ? ExternalReference(IC_Utility(kKeyedLoadIC_MissForceGeneric),
|
| - masm->isolate())
|
| - : ExternalReference(IC_Utility(kKeyedLoadIC_Miss), masm->isolate());
|
| + ExternalReference ref =
|
| + ExternalReference(IC_Utility(kKeyedLoadIC_Miss), masm->isolate());
|
| __ TailCallExternalReference(ref, 2, 1);
|
| }
|
|
|
| @@ -1551,7 +1549,7 @@ void KeyedStoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
|
| }
|
|
|
|
|
| -void KeyedStoreIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) {
|
| +void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
|
| // ----------- S t a t e -------------
|
| // -- eax : value
|
| // -- ecx : key
|
| @@ -1566,10 +1564,8 @@ void KeyedStoreIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) {
|
| __ push(ebx);
|
|
|
| // Do tail-call to runtime routine.
|
| - ExternalReference ref = miss_mode == MISS_FORCE_GENERIC
|
| - ? ExternalReference(IC_Utility(kKeyedStoreIC_MissForceGeneric),
|
| - masm->isolate())
|
| - : ExternalReference(IC_Utility(kKeyedStoreIC_Miss), masm->isolate());
|
| + ExternalReference ref =
|
| + ExternalReference(IC_Utility(kKeyedStoreIC_Miss), masm->isolate());
|
| __ TailCallExternalReference(ref, 3, 1);
|
| }
|
|
|
|
|