| Index: src/x64/ic-x64.cc
|
| diff --git a/src/x64/ic-x64.cc b/src/x64/ic-x64.cc
|
| index 721ae1d982aa9279dff7845b326da554459de690..667a52305d7f5a03ff9504b153b93a5b26bad206 100644
|
| --- a/src/x64/ic-x64.cc
|
| +++ b/src/x64/ic-x64.cc
|
| @@ -540,7 +540,7 @@ void KeyedLoadIC::GenerateString(MacroAssembler* masm) {
|
| char_at_generator.GenerateSlow(masm, call_helper);
|
|
|
| __ bind(&miss);
|
| - GenerateMiss(masm, MISS);
|
| + GenerateMiss(masm);
|
| }
|
|
|
|
|
| @@ -583,7 +583,7 @@ void KeyedLoadIC::GenerateIndexedInterceptor(MacroAssembler* masm) {
|
| 1);
|
|
|
| __ bind(&slow);
|
| - GenerateMiss(masm, MISS);
|
| + GenerateMiss(masm);
|
| }
|
|
|
|
|
| @@ -749,10 +749,10 @@ void KeyedStoreIC::GenerateGeneric(MacroAssembler* masm,
|
| __ JumpIfSmi(rdx, &slow_with_tagged_index);
|
| // Get the map from the receiver.
|
| __ movq(r9, FieldOperand(rdx, HeapObject::kMapOffset));
|
| - // Check that the receiver does not require access checks. We need
|
| - // to do this because this generic stub does not perform map checks.
|
| + // Check that the receiver does not require access checks and is not observed.
|
| + // The generic stub does not perform map checks or handle observed objects.
|
| __ testb(FieldOperand(r9, Map::kBitFieldOffset),
|
| - Immediate(1 << Map::kIsAccessCheckNeeded));
|
| + Immediate(1 << Map::kIsAccessCheckNeeded | 1 << Map::kIsObserved));
|
| __ j(not_zero, &slow_with_tagged_index);
|
| // Check that the key is a smi.
|
| __ JumpIfNotSmi(rcx, &slow_with_tagged_index);
|
| @@ -1271,7 +1271,7 @@ void KeyedLoadIC::GenerateNonStrictArguments(MacroAssembler* masm) {
|
| __ movq(rax, unmapped_location);
|
| __ Ret();
|
| __ bind(&slow);
|
| - GenerateMiss(masm, MISS);
|
| + GenerateMiss(masm);
|
| }
|
|
|
|
|
| @@ -1310,7 +1310,7 @@ void KeyedStoreIC::GenerateNonStrictArguments(MacroAssembler* masm) {
|
| INLINE_SMI_CHECK);
|
| __ Ret();
|
| __ bind(&slow);
|
| - GenerateMiss(masm, MISS);
|
| + GenerateMiss(masm);
|
| }
|
|
|
|
|
| @@ -1423,7 +1423,7 @@ void LoadIC::GenerateRuntimeGetProperty(MacroAssembler* masm) {
|
| }
|
|
|
|
|
| -void KeyedLoadIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) {
|
| +void KeyedLoadIC::GenerateMiss(MacroAssembler* masm) {
|
| // ----------- S t a t e -------------
|
| // -- rax : key
|
| // -- rdx : receiver
|
| @@ -1439,10 +1439,8 @@ void KeyedLoadIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) {
|
| __ PushReturnAddressFrom(rbx);
|
|
|
| // Perform tail call to the entry.
|
| - ExternalReference ref = miss_mode == MISS_FORCE_GENERIC
|
| - ? ExternalReference(IC_Utility(kKeyedLoadIC_MissForceGeneric),
|
| - masm->isolate())
|
| - : ExternalReference(IC_Utility(kKeyedLoadIC_Miss), masm->isolate());
|
| + ExternalReference ref =
|
| + ExternalReference(IC_Utility(kKeyedLoadIC_Miss), masm->isolate());
|
| __ TailCallExternalReference(ref, 2, 1);
|
| }
|
|
|
| @@ -1612,7 +1610,7 @@ void KeyedStoreIC::GenerateSlow(MacroAssembler* masm) {
|
| }
|
|
|
|
|
| -void KeyedStoreIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) {
|
| +void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
|
| // ----------- S t a t e -------------
|
| // -- rax : value
|
| // -- rcx : key
|
| @@ -1627,10 +1625,8 @@ void KeyedStoreIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) {
|
| __ PushReturnAddressFrom(rbx);
|
|
|
| // Do tail-call to runtime routine.
|
| - ExternalReference ref = miss_mode == MISS_FORCE_GENERIC
|
| - ? ExternalReference(IC_Utility(kKeyedStoreIC_MissForceGeneric),
|
| - masm->isolate())
|
| - : ExternalReference(IC_Utility(kKeyedStoreIC_Miss), masm->isolate());
|
| + ExternalReference ref =
|
| + ExternalReference(IC_Utility(kKeyedStoreIC_Miss), masm->isolate());
|
| __ TailCallExternalReference(ref, 3, 1);
|
| }
|
|
|
|
|