Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7790)

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.h

Issue 1105713002: [Extension Toolbar] Slide out overflowed actions for popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_popup.h
diff --git a/chrome/browser/ui/views/extensions/extension_popup.h b/chrome/browser/ui/views/extensions/extension_popup.h
index 4b6d0c06c8e49b232fc5ed90b17df62b1c5fcd3b..cf590cccc0309130d6385a6b2823e44c384c5096 100644
--- a/chrome/browser/ui/views/extensions/extension_popup.h
+++ b/chrome/browser/ui/views/extensions/extension_popup.h
@@ -40,20 +40,20 @@ class ExtensionPopup : public views::BubbleDelegateView,
~ExtensionPopup() override;
- // Create and show a popup with |url| positioned adjacent to |anchor_view|.
- // |browser| is the browser to which the pop-up will be attached. NULL is a
- // valid parameter for pop-ups not associated with a browser.
+ // Create and show a popup with the given |host| positioned adjacent to
+ // |anchor_view|.
// The positioning of the pop-up is determined by |arrow| according to the
- // following logic: The popup is anchored so that the corner indicated by the
+ // following logic: The popup is anchored so that the corner indicated by the
// value of |arrow| remains fixed during popup resizes. If |arrow| is
// BOTTOM_*, then the popup 'pops up', otherwise the popup 'drops down'.
// The actual display of the popup is delayed until the page contents
// finish loading in order to minimize UI flashing and resizing.
- static ExtensionPopup* ShowPopup(const GURL& url,
- Browser* browser,
- views::View* anchor_view,
- views::BubbleBorder::Arrow arrow,
- ShowAction show_action);
+ static ExtensionPopup* ShowPopup(
+ scoped_ptr<extensions::ExtensionViewHost> host,
+ views::View* anchor_view,
+ views::BubbleBorder::Arrow arrow,
+ ShowAction show_action);
+
extensions::ExtensionViewHost* host() const { return host_.get(); }

Powered by Google App Engine
This is Rietveld 408576698