Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/ui/extensions/extension_action_platform_delegate.h

Issue 1105713002: [Extension Toolbar] Slide out overflowed actions for popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/extension_action_platform_delegate.h
diff --git a/chrome/browser/ui/extensions/extension_action_platform_delegate.h b/chrome/browser/ui/extensions/extension_action_platform_delegate.h
index d4d3dc72a25472d06930db888ca6a0732863e501..5343d3163b9d02d55614094fa115ba57d9abd55c 100644
--- a/chrome/browser/ui/extensions/extension_action_platform_delegate.h
+++ b/chrome/browser/ui/extensions/extension_action_platform_delegate.h
@@ -30,16 +30,16 @@ class ExtensionActionPlatformDelegate {
// Called once the delegate is set, in order to do any extra initialization.
virtual void OnDelegateSet() = 0;
- // Shows the popup for the extension action, given the associated |popup_url|.
- // |grant_tab_permissions| is true if active tab permissions should be given
- // to the extension; this is only true if the popup is opened through a user
- // action.
- // Returns the ExtensionViewHost of the created popup, if a popup is
- // successfully shown.
- virtual extensions::ExtensionViewHost* ShowPopupWithUrl(
- ExtensionActionViewController::PopupShowAction show_action,
- const GURL& popup_url,
- bool grant_tab_permissions) = 0;
+ // Shows the given |host|. |grant_tab_permissions| is true if active tab
+ // permissions should be given to the extension; this is only true if the
+ // popup is opened through a user action.
+ virtual void ShowPopup(
+ scoped_ptr<extensions::ExtensionViewHost> host,
+ bool grant_tab_permissions,
+ ExtensionActionViewController::PopupShowAction show_action) = 0;
+
+ // Closes the overflow menu, if it was open.
+ virtual void CloseOverflowMenu() = 0;
};
#endif // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_ACTION_PLATFORM_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698