chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h - Issue 1105713002: [Extension Toolbar] Slide out overflowed actions for popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

Issue 1105713002: [Extension Toolbar] Slide out overflowed actions for popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h b/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

index dfe55aa2379b2be0f35a5a411993c13c5c83cec0..889db368fb22a6b19ab67a707ca069b51de8ebc4 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

@@ -26,10 +26,11 @@ class ExtensionActionPlatformDelegateCocoa

bool IsMenuRunning() const override;

void RegisterCommand() override;

void OnDelegateSet() override;

- extensions::ExtensionViewHost* ShowPopupWithUrl(

- ExtensionActionViewController::PopupShowAction show_action,

- const GURL& popup_url,

- bool grant_tab_permissions) override;

+ void ShowPopup(

+ scoped_ptr<extensions::ExtensionViewHost> host,

+ bool grant_tab_permissions,

+ ExtensionActionViewController::PopupShowAction show_action) override;

+ void CloseOverflowMenu() override;

// content::NotificationObserver:

void Observe(int type,