chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm - Issue 1105713002: [Extension Toolbar] Slide out overflowed actions for popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

Issue 1105713002: [Extension Toolbar] Slide out overflowed actions for popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_action_button.mm ('k') | chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h » ('j') | chrome/browser/ui/toolbar/toolbar_actions_bar.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm b/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

index c156fd8802bc14e512245f882fd247ec37cc2cc1..c418c98b3c48a3d6cd7b1fb96cf5cdbada6ad8ab 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

@@ -157,11 +157,13 @@ std::string BrowserActionTestUtil::GetTooltip(int index) {

}

gfx::NativeView BrowserActionTestUtil::GetPopupNativeView() {

- return [[ExtensionPopupController popup] view];

+ ToolbarActionViewController* popup_owner =

+ GetToolbarActionsBar()->popup_owner();

+ return popup_owner ? popup_owner->GetPopupNativeView() : nullptr;

}

bool BrowserActionTestUtil::HasPopup() {

- return [ExtensionPopupController popup] != nil;

+ return GetPopupNativeView() != nullptr;

}

gfx::Size BrowserActionTestUtil::GetPopupSize() {