[Extension Toolbar] Slide out overflowed actions for popups

chrome/browser/ui/extensions/extension_action_view_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_ACTION_VIEW_CONTROLLER_H_
 #define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_ACTION_VIEW_CONTROLLER_H_
 
+#include "base/memory/weak_ptr.h"
 #include "base/scoped_observer.h"
 #include "chrome/browser/extensions/extension_action_icon_factory.h"
 #include "chrome/browser/extensions/extension_context_menu_model.h"
 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
 #include "extensions/browser/extension_host_observer.h"
 #include "ui/gfx/image/image.h"
 
 class Browser;
 class ExtensionAction;
 class ExtensionActionPlatformDelegate;
@@ skipping 50 matching lines @@
                   const gfx::Rect& bounds,
                   content::WebContents* web_contents) const override;
   void RegisterCommand() override;
 
   // ExtensionContextMenuModel::PopupDelegate:
   void InspectPopup() override;
 
   // Closes the active popup (whether it was this action's popup or not).
   void HideActivePopup();
 
+  // Handles cleanup after a menu closes.
+  void OnMenuClosed();
+
   // Populates |command| with the command associated with |extension|, if one
   // exists. Returns true if |command| was populated.
   bool GetExtensionCommand(extensions::Command* command);
 
   const extensions::Extension* extension() const { return extension_; }
   Browser* browser() { return browser_; }
   ExtensionAction* extension_action() { return extension_action_; }
   const ExtensionAction* extension_action() const { return extension_action_; }
   ToolbarActionViewDelegate* view_delegate() { return view_delegate_; }
   bool is_showing_popup() const { return popup_host_ != nullptr; }
@@ skipping 19 matching lines @@
   // ToolbarActionViewController should be used for showing popups. This
   // returns the preferred controller.
   ExtensionActionViewController* GetPreferredPopupViewController();
 
   // Executes the extension action with |show_action|. If
   // |grant_tab_permissions| is true, this will grant the extension active tab
   // permissions. Only do this if this was done through a user action (and not
   // e.g. an API). Returns true if a popup is shown.
   bool ExecuteAction(PopupShowAction show_action, bool grant_tab_permissions);
 
-  // Shows the popup for the extension action, given the associated |popup_url|.
-  // |grant_tab_permissions| is true if active tab permissions should be given
-  // to the extension; this is only true if the popup is opened through a user
-  // action.
-  // Returns true if a popup is successfully shown.
-  bool ShowPopupWithUrl(PopupShowAction show_action,
-                        const GURL& popup_url,
-                        bool grant_tab_permissions);
+  // Begins the process of showing the popup for the extension action, given the
+  // associated |popup_url|. |grant_tab_permissions| is true if active tab
+  // permissions should be given to the extension; this is only true if the
+  // popup is opened through a user action.
+  // The popup may not be shown synchronously if the extension is hidden and
+  // first needs to slide itself out.
+  // Returns true if a popup will be shown.
+  bool TriggerPopupWithUrl(PopupShowAction show_action,
+                           const GURL& popup_url,
+                           bool grant_tab_permissions);
+
+  // Shows the popup with the given |host|.
+  void ShowPopup(scoped_ptr<extensions::ExtensionViewHost> host,
+                 bool grant_tab_permissions,
+                 PopupShowAction show_action);
 
   // Handles cleanup after the popup closes.
   void OnPopupClosed();
 
   // The extension associated with the action we're displaying.
   const extensions::Extension* extension_;
 
   // The corresponding browser.
   Browser* browser_;
 
@@ skipping 29 matching lines @@
   // An additional observer that we need to notify when the icon of the button
   // has been updated.
   ExtensionActionIconFactory::Observer* icon_observer_;
 
   // The associated ExtensionRegistry; cached for quick checking.
   extensions::ExtensionRegistry* extension_registry_;
 
   ScopedObserver<extensions::ExtensionHost, extensions::ExtensionHostObserver>
       popup_host_observer_;
 
+  base::WeakPtrFactory<ExtensionActionViewController> weak_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(ExtensionActionViewController);
 };
 
 #endif  // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_ACTION_VIEW_CONTROLLER_H_