Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1105703002: Revert of mac: Add the flag "-gline-tables-only" to reduce dSYM size. (Closed)

Created:
5 years, 8 months ago by erikchen
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Add the flag "-gline-tables-only" to reduce dSYM size. (patchset #4 id:60001 of https://codereview.chromium.org/1085843004/) Reason for revert: Reverting this CL because it doesn't actually reduce the dSYM size generated by dsymutil. Original issue's description: > mac: Add the flag "-gline-tables-only" to reduce dSYM size. > > The dSYM for Google Chrome Framework has grown to be larger than 4GB. dsymutil > can't handle this. Reduce the amount of debug info output for official builds > of Google Chrome. On my local machine, the dSYM is 10x smaller. > > BUG=479841 > > Committed: https://crrev.com/c4fc98d94448349b8fcf3d0627a166c74caf7053 > Cr-Commit-Position: refs/heads/master@{#326445} TBR=mark@chromium.org,rsesek@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=479841 Committed: https://crrev.com/5cf3c2e114b5d28a7997703ad6fea052a7a9f705 Cr-Commit-Position: refs/heads/master@{#326589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of mac: Add the flag "-gline-tables-only" to reduce dSYM size.
5 years, 8 months ago (2015-04-23 18:28:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105703002/1
5 years, 8 months ago (2015-04-23 18:29:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 18:32:50 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 18:34:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cf3c2e114b5d28a7997703ad6fea052a7a9f705
Cr-Commit-Position: refs/heads/master@{#326589}

Powered by Google App Engine
This is Rietveld 408576698