Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6834)

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 1105683003: [Extensions Page] Add a listener on extension list for "hasExtensions" changing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Dan's Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extensions.js
diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js
index e094312bba88eb769323613216a95ca2a3c30158..f95e625223554fd7b7184470b5991df4247b3b9b 100644
--- a/chrome/browser/resources/extensions/extensions.js
+++ b/chrome/browser/resources/extensions/extensions.js
@@ -274,14 +274,24 @@ cr.define('extensions', function() {
document.documentElement.classList.remove('loading');
}, 0);
- /** @const */
- var hasExtensions = extensionList.getNumExtensions() != 0;
- $('no-extensions').hidden = hasExtensions;
- $('extension-list-wrapper').hidden = !hasExtensions;
+ extensionList.onExtensionCountChanged =
+ this.updateListVisibility_.bind(this);
+ this.updateListVisibility_();
Dan Beam 2015/04/27 16:17:05 why does the |this| matter at all for this method?
}.bind(this));
},
/**
+ * Updates the visibility of the extension list and "Boo..." message.
+ * @private
+ */
+ updateListVisibility_: function() {
Dan Beam 2015/04/27 16:17:05 make this static
Devlin 2015/04/27 18:28:30 Now, since this is a delegate method, I don't thin
Dan Beam 2015/04/27 18:47:59 fine as is
+ /** @const */
+ var hasExtensions = $('extension-settings-list').getNumExtensions() != 0;
+ $('no-extensions').hidden = hasExtensions;
+ $('extension-list-wrapper').hidden = !hasExtensions;
+ },
+
+ /**
* Handles the Pack Extension button.
* @param {Event} e Change event.
* @private

Powered by Google App Engine
This is Rietveld 408576698