Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2094)

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 1105683003: [Extensions Page] Add a listener on extension list for "hasExtensions" changing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extensions.js
diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js
index 06b62379a5112d70932832ca49299da59d6b61a3..73729c46c76b1d28ea47f432d6417dcd1df711ea 100644
--- a/chrome/browser/resources/extensions/extensions.js
+++ b/chrome/browser/resources/extensions/extensions.js
@@ -274,11 +274,15 @@ cr.define('extensions', function() {
document.documentElement.classList.remove('loading');
}, 0);
- /** @const */
- var hasExtensions = extensionList.getNumExtensions() != 0;
- $('no-extensions').hidden = hasExtensions;
- $('extension-list-wrapper').hidden = !hasExtensions;
- $('extension-settings-list').updateFocusableElements();
+ var onHasExtensionsChanged = function() {
Dan Beam 2015/04/23 18:01:39 onExtensionChanged (or at the very least HaveExten
Devlin 2015/04/23 18:27:31 How about onExtensionCountChanged? (Before, it wa
+ /** @const */
+ var hasExtensions = extensionList.getNumExtensions() != 0;
+ $('no-extensions').hidden = hasExtensions;
+ $('extension-list-wrapper').hidden = !hasExtensions;
+ $('extension-settings-list').updateFocusableElements();
+ };
Dan Beam 2015/04/23 18:01:38 make this a permanent instance or static method in
Devlin 2015/04/23 18:27:31 Done.
+ extensionList.onHasExtensionsChanged = onHasExtensionsChanged;
+ onHasExtensionsChanged();
}.bind(this));
},

Powered by Google App Engine
This is Rietveld 408576698