Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: cloud_print/cloud_print_resources.gyp

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome_elf/chrome_elf.gyp ('k') | media/media_cdm.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 'chromium_code': 1, 6 'chromium_code': 1,
7 7
8 'variables': { 8 'variables': {
9 'branding_path': '<(DEPTH)/chrome/app/theme/<(branding_path_component)/BRA NDING',
9 'version_py_path': '<(DEPTH)/build/util/version.py', 10 'version_py_path': '<(DEPTH)/build/util/version.py',
10 'version_path': 'VERSION', 11 'version_path': 'VERSION',
11 }, 12 },
12 'version_py_path': '<(version_py_path) -f', 13 'version_py_path': '<(version_py_path) -f',
13 'version_path': '<(version_path)', 14 'version_path': '<(version_path)',
14 }, 15 },
15 'includes': [ 16 'includes': [
16 '../build/util/version.gypi', 17 '../build/util/version.gypi',
17 ], 18 ],
18 'targets': [ 19 'targets': [
19 { 20 {
20 'target_name': 'cloud_print_version_resources', 21 'target_name': 'cloud_print_version_resources',
21 'type': 'none', 22 'type': 'none',
22 'conditions': [
23 ['branding == "Chrome"', {
24 'variables': {
25 'branding_path': '<(DEPTH)/chrome/app/theme/google_chrome/BRANDING' ,
26 },
27 }, { # else branding!="Chrome"
28 'variables': {
29 'branding_path': '<(DEPTH)/chrome/app/theme/chromium/BRANDING',
30 },
31 }],
32 ],
33 'variables': { 23 'variables': {
34 'output_dir': 'cloud_print', 24 'output_dir': 'cloud_print',
35 'template_input_path': '../chrome/app/chrome_version.rc.version', 25 'template_input_path': '../chrome/app/chrome_version.rc.version',
36 'extra_variable_files_arguments': [ '-f', 'BRANDING' ], 26 'extra_variable_files_arguments': [ '-f', 'BRANDING' ],
37 'extra_variable_files': [ 'BRANDING' ], # NOTE: matches that above 27 'extra_variable_files': [ 'BRANDING' ], # NOTE: matches that above
38 }, 28 },
39 'direct_dependent_settings': { 29 'direct_dependent_settings': {
40 'include_dirs': [ 30 'include_dirs': [
41 '<(SHARED_INTERMEDIATE_DIR)/<(output_dir)', 31 '<(SHARED_INTERMEDIATE_DIR)/<(output_dir)',
42 ], 32 ],
43 }, 33 },
44 'sources': [ 34 'sources': [
45 'service/win/cloud_print_service_exe.ver', 35 'service/win/cloud_print_service_exe.ver',
46 'service/win/cloud_print_service_config_exe.ver', 36 'service/win/cloud_print_service_config_exe.ver',
47 'service/win/cloud_print_service_setup_exe.ver', 37 'service/win/cloud_print_service_setup_exe.ver',
48 'virtual_driver/win/gcp_portmon64_dll.ver', 38 'virtual_driver/win/gcp_portmon64_dll.ver',
49 'virtual_driver/win/gcp_portmon_dll.ver', 39 'virtual_driver/win/gcp_portmon_dll.ver',
50 'virtual_driver/win/install/virtual_driver_setup_exe.ver', 40 'virtual_driver/win/install/virtual_driver_setup_exe.ver',
51 ], 41 ],
52 'includes': [ 42 'includes': [
53 '../chrome/version_resource_rules.gypi', 43 '../chrome/version_resource_rules.gypi',
54 ], 44 ],
55 }, 45 },
56 { 46 {
57 'target_name': 'cloud_print_version_header', 47 'target_name': 'cloud_print_version_header',
58 'type': 'none', 48 'type': 'none',
59 'conditions': [
60 ['branding == "Chrome"', {
61 'variables': {
62 'branding_path': '<(DEPTH)/chrome/app/theme/google_chrome/BRANDING' ,
63 },
64 }, { # else branding!="Chrome"
65 'variables': {
66 'branding_path': '<(DEPTH)/chrome/app/theme/chromium/BRANDING',
67 },
68 }],
69 ],
70 'hard_dependency': 1, 49 'hard_dependency': 1,
71 'actions': [ 50 'actions': [
72 { 51 {
73 'action_name': 'version_header', 52 'action_name': 'version_header',
74 'variables': { 53 'variables': {
75 'output_dir': 'cloud_print', 54 'output_dir': 'cloud_print',
76 'lastchange_path': 55 'lastchange_path':
77 '<(DEPTH)/build/util/LASTCHANGE', 56 '<(DEPTH)/build/util/LASTCHANGE',
78 }, 57 },
79 'direct_dependent_settings': { 58 'direct_dependent_settings': {
(...skipping 20 matching lines...) Expand all
100 '-f', 'BRANDING', 79 '-f', 'BRANDING',
101 '<(DEPTH)/chrome/version.h.in', 80 '<(DEPTH)/chrome/version.h.in',
102 '<@(_outputs)', 81 '<@(_outputs)',
103 ], 82 ],
104 'message': 'Generating version header file: <@(_outputs)', 83 'message': 'Generating version header file: <@(_outputs)',
105 }, 84 },
106 ], 85 ],
107 }, 86 },
108 ], 87 ],
109 } 88 }
OLDNEW
« no previous file with comments | « chrome_elf/chrome_elf.gyp ('k') | media/media_cdm.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698