Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: chrome/installer/mini_installer_syzygy.gyp

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/mini_installer.gyp ('k') | chrome/installer/upgrade_test.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 'version_py': '<(DEPTH)/build/util/version.py', 6 'version_py': '<(DEPTH)/build/util/version.py',
7 'version_path': '<(DEPTH)/chrome/VERSION', 7 'version_path': '<(DEPTH)/chrome/VERSION',
8 'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE', 8 'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE',
9 # 'branding_dir' is set in the 'conditions' section at the bottom. 9 'branding_dir': '../app/theme/<(branding_path_component)',
10 'msvs_use_common_release': 0, 10 'msvs_use_common_release': 0,
11 'msvs_use_common_linker_extras': 0, 11 'msvs_use_common_linker_extras': 0,
12 }, 12 },
13 'includes': [ 13 'includes': [
14 '../../build/win_precompile.gypi', 14 '../../build/win_precompile.gypi',
15 ], 15 ],
16 'conditions': [ 16 'conditions': [
17 # This target won't build in fastbuild, since there are no PDBs. 17 # This target won't build in fastbuild, since there are no PDBs.
18 ['OS=="win" and fastbuild==0', { 18 ['OS=="win" and fastbuild==0', {
19 'conditions': [ 19 'conditions': [
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 }, 57 },
58 # Bulk of the build configuration comes from here. 58 # Bulk of the build configuration comes from here.
59 'includes': [ 'mini_installer.gypi', ], 59 'includes': [ 'mini_installer.gypi', ],
60 }, 60 },
61 ], 61 ],
62 }], 62 }],
63 ], 63 ],
64 },{ 64 },{
65 'targets': [], 65 'targets': [],
66 }], 66 }],
67 [ 'branding == "Chrome"', {
68 'variables': {
69 'branding_dir': '../app/theme/google_chrome',
70 },
71 }, { # else branding!="Chrome"
72 'variables': {
73 'branding_dir': '../app/theme/chromium',
74 },
75 }],
76 ], 67 ],
77 } 68 }
OLDNEW
« no previous file with comments | « chrome/installer/mini_installer.gyp ('k') | chrome/installer/upgrade_test.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698