Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: chrome/installer/installer_tools.gyp

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome_installer.gypi ('k') | chrome/installer/mini_installer.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'version_py': '<(DEPTH)/build/util/version.py', 7 'version_py': '<(DEPTH)/build/util/version.py',
8 'version_path': '<(DEPTH)/chrome/VERSION', 8 'version_path': '<(DEPTH)/chrome/VERSION',
9 'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE', 9 'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE',
10 # 'branding_dir' is set in the 'conditions' section at the bottom. 10 'branding_dir': '<(DEPTH)/chrome/app/theme/<(branding_path_component)',
11 'msvs_use_common_release': 0, 11 'msvs_use_common_release': 0,
12 'msvs_use_common_linker_extras': 0, 12 'msvs_use_common_linker_extras': 0,
13 }, 13 },
14 'conditions': [ 14 'conditions': [
15 ['OS=="win"', { 15 ['OS=="win"', {
16 'targets': [ 16 'targets': [
17 { 17 {
18 'target_name': 'validate_installation', 18 'target_name': 'validate_installation',
19 'type': 'executable', 19 'type': 'executable',
20 'dependencies': [ 20 'dependencies': [
21 '<(DEPTH)/base/base.gyp:base', 21 '<(DEPTH)/base/base.gyp:base',
22 '<(DEPTH)/chrome/chrome.gyp:installer_util', 22 '<(DEPTH)/chrome/chrome.gyp:installer_util',
23 '<(DEPTH)/chrome/chrome.gyp:installer_util_strings', 23 '<(DEPTH)/chrome/chrome.gyp:installer_util_strings',
24 '<(DEPTH)/chrome/common_constants.gyp:common_constants', 24 '<(DEPTH)/chrome/common_constants.gyp:common_constants',
25 ], 25 ],
26 'include_dirs': [ 26 'include_dirs': [
27 '<(DEPTH)', 27 '<(DEPTH)',
28 ], 28 ],
29 'sources': [ 29 'sources': [
30 'tools/validate_installation.rc', 30 'tools/validate_installation.rc',
31 'tools/validate_installation_main.cc', 31 'tools/validate_installation_main.cc',
32 'tools/validate_installation_resource.h', 32 'tools/validate_installation_resource.h',
33 ], 33 ],
34 }, 34 },
35 ], 35 ],
36 }], 36 }],
37 [ 'branding == "Chrome"', {
38 'variables': {
39 'branding_dir': '<(DEPTH)/chrome/app/theme/google_chrome',
40 },
41 }, { # else branding!="Chrome"
42 'variables': {
43 'branding_dir': '<(DEPTH)/chrome/app/theme/chromium',
44 },
45 }],
46 ], 37 ],
47 } 38 }
OLDNEW
« no previous file with comments | « chrome/chrome_installer.gypi ('k') | chrome/installer/mini_installer.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698