Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1105633002: Add glBlendEquation to skia GL bindings (Closed)

Created:
5 years, 8 months ago by Chris Dalton
Modified:
5 years, 8 months ago
Reviewers:
bsalomon, no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add glBlendEquation to skia GL bindings BUG= Committed: https://crrev.com/3c807e8ff9f6ebd2a3a8bbf3c3db5c1dad7d1a47 Cr-Commit-Position: refs/heads/master@{#326673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_bindings_skia_in_process.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Chris Dalton
Brian, I know you might not the right one to ask for a review here, ...
5 years, 8 months ago (2015-04-23 08:35:44 UTC) #2
bsalomon
LGTM, adding sievers@
5 years, 8 months ago (2015-04-23 14:48:09 UTC) #4
no sievers
lgtm
5 years, 8 months ago (2015-04-23 20:34:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105633002/1
5 years, 8 months ago (2015-04-23 20:37:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 22:34:38 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 22:35:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c807e8ff9f6ebd2a3a8bbf3c3db5c1dad7d1a47
Cr-Commit-Position: refs/heads/master@{#326673}

Powered by Google App Engine
This is Rietveld 408576698