Use of base::StringPairs appropriately in backend_unittest

Use of base::StringPairs appropriately in backend_unittest

Because base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250
Committed: https://crrev.com/08411b749deed07132ff1390eacfb55ce74890c8
Cr-Commit-Position: refs/heads/master@{#327560}

[payal.pandey, 2015-04-23 07:08:15]

payal.pandey@samsung.com changed reviewers:
+ mattm@chromium.org

[payal.pandey, 2015-04-23 07:08:15]

Please have a look, Thanks.

[payal.pandey, 2015-04-23 10:13:53]

payal.pandey@samsung.com changed reviewers:
+ avi@chromium.org

[mattm, 2015-04-23 10:17:49]

On 2015/04/23 07:08:15, payal.pandey wrote:
> Please have a look, Thanks.

Just because some header somewhere defines a typedef of the same thing, doesn't
mean it should be used in a totally unrelated place.

[payal.pandey, 2015-04-23 10:40:17]

On 2015/04/23 10:17:49, mattm wrote:
> On 2015/04/23 07:08:15, payal.pandey wrote:
> > Please have a look, Thanks.
> 
> Just because some header somewhere defines a typedef of the same thing,
doesn't
> mean it should be used in a totally unrelated place

Thanks for your feedback.
Included the base/strings/string_split.h header file here.
Please check again.

[payal.pandey, 2015-04-23 10:40:53]

Please have a look again, Thanks

[mattm, 2015-04-23 11:48:03]

On 2015/04/23 10:40:17, payal.pandey wrote:
> On 2015/04/23 10:17:49, mattm wrote:
> > On 2015/04/23 07:08:15, payal.pandey wrote:
> > > Please have a look, Thanks.
> > 
> > Just because some header somewhere defines a typedef of the same thing,
> doesn't
> > mean it should be used in a totally unrelated place
> 
> Thanks for your feedback.
> Included the base/strings/string_split.h header file here.
> Please check again.

That wasn't what I meant. This code doesn't use SplitStringIntoKeyValuePairs and
doesn't have anything to do with splitting strings into pairs. Just because the
typedef has the same type doesn't mean it should be used here.

[payal.pandey, 2015-04-29 19:34:06]

payal.pandey@samsung.com changed reviewers:
+ eroman@chromium.org
- avi@chromium.org

[payal.pandey, 2015-04-29 19:35:23]

@eroman: Could this CL be updated, if possible.
Please have a look, Thanks.

[eroman, 2015-04-29 19:36:34]

lgtm

[payal.pandey, 2015-04-29 19:37:55]

The CQ bit was checked by payal.pandey@samsung.com

[commit-bot: I haz the power, 2015-04-29 19:40:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1105623002/20001

[commit-bot: I haz the power, 2015-04-29 21:30:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-29 21:31:51]

Patchset 2 (id:??) landed as
https://crrev.com/08411b749deed07132ff1390eacfb55ce74890c8
Cr-Commit-Position: refs/heads/master@{#327560}