[MacViews] Implement AlwaysOnTop and VisibleOnAllWorkspaces.

ui/views/widget/native_widget_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/native_widget_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #import "ui/base/cocoa/window_size_constants.h"
 #include "ui/gfx/font_list.h"
 #import "ui/gfx/mac/coordinate_conversion.h"
+#import "ui/gfx/mac/nswindow_frame_controls.h"
 #include "ui/native_theme/native_theme.h"
 #import "ui/views/cocoa/bridged_content_view.h"
 #import "ui/views/cocoa/bridged_native_widget.h"
 #import "ui/views/cocoa/native_widget_mac_nswindow.h"
 #import "ui/views/cocoa/views_nswindow_delegate.h"
 #include "ui/views/window/native_frame_view.h"
 
 namespace views {
 namespace {
 
@@ skipping 51 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeWidgetMac, internal::NativeWidgetPrivate implementation:
 
 void NativeWidgetMac::InitNativeWidget(const Widget::InitParams& params) {
   ownership_ = params.ownership;
   base::scoped_nsobject<NSWindow> window([CreateNSWindow(params) retain]);
   [window setReleasedWhenClosed:NO];  // Owned by scoped_nsobject.
   bridge_->Init(window, params);
 
+  SetAlwaysOnTop(params.keep_on_top);

[tapted, 2015/05/12 04:05:35]

I think... only call this when params.keep_on_top is true. But comment. i.e.

// Only set the always on top property during Init if it is true, since setting
// it can affect how the window is treated by Exposé.


Other options could be
 - only change collection behavior in SetAlwaysOnTop if it is being set `true`
  ( - but then should we try to restore when going to false?)
 - only change collection behavior in SetAlwaysOnTop if (collectionBehavior & (
NSWindowCollectionBehaviorManaged | NSWindowCollectionBehaviorTransient |
NSWindowCollectionBehaviorStationary)) is zero
  ( - i.e. nothing has tried to set it already, but then... what if something
later wants to set it?)


So I think if a window never opt in to always-on-top, we should just leave the
collection behavior alone.

[jackhou1, 2015/05/12 05:44:19]

Done.

+
   delegate_->OnNativeWidgetCreated(true);
 
   bridge_->SetFocusManager(GetWidget()->GetFocusManager());
 
   DCHECK(GetWidget()->GetRootView());
   bridge_->SetRootView(GetWidget()->GetRootView());
 
   // "Infer" must be handled by ViewsDelegate::OnBeforeWidgetInit().
   DCHECK_NE(Widget::InitParams::INFER_OPACITY, params.opacity);
   bool translucent = params.opacity == Widget::InitParams::TRANSLUCENT_WINDOW;
@@ skipping 274 matching lines @@
 
 void NativeWidgetMac::Deactivate() {
   NOTIMPLEMENTED();
 }
 
 bool NativeWidgetMac::IsActive() const {
   return [GetNativeWindow() isKeyWindow];
 }
 
 void NativeWidgetMac::SetAlwaysOnTop(bool always_on_top) {
-  NOTIMPLEMENTED();
+  gfx::SetNSWindowAlwaysOnTop(GetNativeWindow(), always_on_top);
 }
 
 bool NativeWidgetMac::IsAlwaysOnTop() const {
-  NOTIMPLEMENTED();
-  return false;
+  return gfx::IsNSWindowAlwaysOnTop(GetNativeWindow());
 }
 
 void NativeWidgetMac::SetVisibleOnAllWorkspaces(bool always_visible) {
-  NOTIMPLEMENTED();
+  gfx::SetNSWindowVisibleOnAllWorkspaces(GetNativeWindow(), always_visible);
 }
 
 void NativeWidgetMac::Maximize() {
   NOTIMPLEMENTED();  // See IsMaximized().
 }
 
 void NativeWidgetMac::Minimize() {
   NSWindow* window = GetNativeWindow();
   // Calling performMiniaturize: will momentarily highlight the button, but
   // AppKit will reject it if there is no miniaturize button.
@@ skipping 233 matching lines @@
 }
 
 // static
 gfx::FontList NativeWidgetPrivate::GetWindowTitleFontList() {
   NOTIMPLEMENTED();
   return gfx::FontList();
 }
 
 }  // namespace internal
 }  // namespace views