Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 1105573002: cc: Fix invalid opaque debug quads (Closed)

Created:
5 years, 8 months ago by enne (OOO)
Modified:
5 years, 8 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix invalid opaque debug quads It's possible that small debug border quads (when opaque) can get inset so much that they become empty. This causes problems in IPC validating, as the quad rect no longer contains the visible rect (which is empty, due to the insetting). This causes the frame to be invalid, which causes browser rendering artifacts. BUG=472014 Committed: https://crrev.com/b79d5f14c97e62d10fa9b556eef4f50297049036 Cr-Commit-Position: refs/heads/master@{#326618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M cc/layers/layer_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
enne (OOO)
5 years, 8 months ago (2015-04-23 01:42:46 UTC) #2
danakj
LGTM
5 years, 8 months ago (2015-04-23 16:42:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105573002/1
5 years, 8 months ago (2015-04-23 18:42:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 20:00:02 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 20:01:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b79d5f14c97e62d10fa9b556eef4f50297049036
Cr-Commit-Position: refs/heads/master@{#326618}

Powered by Google App Engine
This is Rietveld 408576698