Draw a 2pt white stroke around selection rectangle in overview.

Draw a 2pt white stroke around selection rectangle in overview.

This draws a light stroke around the selection rectangle so that it will be
visible on dark or solid black backgrounds. Additionally the border painting
code was fixed to not draw the corners twice, which with a transparent draw
color was visible as more opaque borders in the corners.

BUG=294860
TEST=visual, enter overview mode (F5) and press arrow key to show selection.

Committed: https://crrev.com/8c81e1627f347d504f06d9e45526a54017ff740a
Cr-Commit-Position: refs/heads/master@{#326812}

[flackr, 2015-04-22 21:19:09]

flackr@chromium.org changed reviewers:
+ sadrul@chromium.org

[flackr, 2015-04-22 21:19:10]

PTAL, thanks!

[sadrul, 2015-04-23 17:05:26]

lgtm

https://codereview.chromium.org/1105563003/diff/1/ash/wm/overview/window_grid.cc
File ash/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/1105563003/diff/1/ash/wm/overview/window_grid...
ash/wm/overview/window_grid.cc:449: selection_widget_->SetOpacity(255);
The opacity change to 255 instead of 128 is deliberate?

[flackr, 2015-04-23 17:11:02]

https://codereview.chromium.org/1105563003/diff/1/ash/wm/overview/window_grid.cc
File ash/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/1105563003/diff/1/ash/wm/overview/window_grid...
ash/wm/overview/window_grid.cc:449: selection_widget_->SetOpacity(255);
On 2015/04/23 17:05:26, sadrul wrote:
> The opacity change to 255 instead of 128 is deliberate?

Yes, The 128 opacity is now part of the background color.

[flackr, 2015-04-24 14:56:33]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2015-04-24 14:57:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1105563003/1

[commit-bot: I haz the power, 2015-04-24 16:14:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-24 16:16:12]

Patchset 1 (id:??) landed as
https://crrev.com/8c81e1627f347d504f06d9e45526a54017ff740a
Cr-Commit-Position: refs/heads/master@{#326812}