Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1105553002: examples/go: http handler & http server (Closed)

Created:
5 years, 8 months ago by rogulenko
Modified:
5 years, 8 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

examples/go: http handler & http server Both applications implement a simple http server. http handler uses mojo http server and provides an http handler; http server uses mojo network service, TCP connections and go net package. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2466990f73456d9f50a4167acc353a430292afe9

Patch Set 1 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -3 lines) Patch
M examples/go/BUILD.gn View 2 chunks +28 lines, -0 lines 2 comments Download
M examples/go/README.txt View 1 chunk +16 lines, -3 lines 0 comments Download
A examples/go/http_handler.go View 1 chunk +108 lines, -0 lines 2 comments Download
A examples/go/http_server.go View 1 chunk +247 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rogulenko
5 years, 8 months ago (2015-04-22 19:14:41 UTC) #3
jamesr
lgtm https://codereview.chromium.org/1105553002/diff/20001/examples/go/BUILD.gn File examples/go/BUILD.gn (right): https://codereview.chromium.org/1105553002/diff/20001/examples/go/BUILD.gn#newcode48 examples/go/BUILD.gn:48: "//mojo/go:application", we should probably put this and the ...
5 years, 8 months ago (2015-04-22 19:21:55 UTC) #4
rogulenko
https://codereview.chromium.org/1105553002/diff/20001/examples/go/BUILD.gn File examples/go/BUILD.gn (right): https://codereview.chromium.org/1105553002/diff/20001/examples/go/BUILD.gn#newcode48 examples/go/BUILD.gn:48: "//mojo/go:application", On 2015/04/22 19:21:55, jamesr wrote: > we should ...
5 years, 8 months ago (2015-04-22 20:49:15 UTC) #5
rogulenko
5 years, 8 months ago (2015-04-22 20:49:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
2466990f73456d9f50a4167acc353a430292afe9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698