Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1105513002: [turbofan] Use FastNewClosureStub if possible. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use FastNewClosureStub if possible. This introduces a JSCreateClosure operator which can be lowered by the typed pipeline to the aforementioned stub. It also allows for further optimizations of closure creation. R=titzer@chromium.org Committed: https://crrev.com/a38f9dddd19a90039f0914b88ab37a3837a3c2f6 Cr-Commit-Position: refs/heads/master@{#28058}

Patch Set 1 #

Patch Set 2 : Add unit test. #

Patch Set 3 : Rebased. #

Total comments: 2

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -4 lines) Patch
M src/code-factory.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 2 3 2 chunks +28 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 2 3 2 chunks +42 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 3 3 chunks +30 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 3 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 8 months ago (2015-04-22 13:20:17 UTC) #1
titzer
https://codereview.chromium.org/1105513002/diff/40001/src/compiler/js-operator.h File src/compiler/js-operator.h (right): https://codereview.chromium.org/1105513002/diff/40001/src/compiler/js-operator.h#newcode211 src/compiler/js-operator.h:211: class CreateClosureParameters final { Make me a struct? https://codereview.chromium.org/1105513002/diff/40001/src/compiler/typer.cc ...
5 years, 8 months ago (2015-04-27 08:38:48 UTC) #2
titzer
lgtm
5 years, 8 months ago (2015-04-27 08:41:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105513002/60001
5 years, 8 months ago (2015-04-27 09:04:56 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-27 09:08:25 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 09:08:40 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a38f9dddd19a90039f0914b88ab37a3837a3c2f6
Cr-Commit-Position: refs/heads/master@{#28058}

Powered by Google App Engine
This is Rietveld 408576698