Converting NodeList to List<Node>.

lib/html/scripts/systemhtml.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the system to generate
 Dart:html APIs from the IDL database."""
 
 import emitter
 
@@ skipping 482 matching lines @@
     self._class_name = self._ImplClassName(self._html_interface_name)
 
     base = None
     if interface.parents:
       supertype = interface.parents[0].type.id
       if IsDartCollectionType(supertype):
         # List methods are injected in AddIndexer.
         pass
       elif IsPureInterface(supertype):
         pass
+      elif supertype == 'NodeList':
+        # Special case as NodeList gets converted to List<Node>.

[Emily Fortuna, 2012/10/03 00:46:21]

These lines shouldn't be necessary. You added NodeList in generator.py, which
populates "nativified_classes", which gets checked in line 475 of this file.

+        base = '_NodeListImpl'
       else:
         base = self._ImplClassName(self._DartType(supertype))
 
     native_spec = MakeNativeSpec(interface.javascript_binding_name)
 
     extends = ' extends ' + base if base else ''
 
     # TODO: Include all implemented interfaces, including other Lists.
     implements = [self._html_interface_name]
     element_type = MaybeTypedArrayElementType(self._interface)
@@ skipping 420 matching lines @@
   def _HasJavaScriptIndexingBehaviour(self):
     """Returns True if the native object has an indexer and length property."""
     (element_type, requires_indexer) = ListImplementationInfo(
         self._interface, self._database)
     if element_type and requires_indexer: return True
     return False
 
   def _ShouldNarrowToImplementationType(self, type_name):
     # TODO(sra): Move into the 'system' and cache the result.
     do_not_narrow = ['DOMStringList', 'DOMStringMap', 'EventListener',
-                     'IDBAny', 'IDBKey', 'MediaQueryListListener']
+                     'IDBAny', 'IDBKey', 'MediaQueryListListener', 'List<Node>',
+                     'NodeList']
     if type_name in do_not_narrow:
       return False
     if self._database.HasInterface(type_name):
       interface = self._database.GetInterface(type_name)
       # Callbacks are typedef functions so don't have a class.
       return 'Callback' not in interface.ext_attrs
     return False
 
   def _NarrowToImplementationType(self, type_name):
     if self._ShouldNarrowToImplementationType(type_name):
@@ skipping 69 matching lines @@
 
     library_emitter = self._multiemitter.FileEmitter(library_file_path)
     library_file_dir = os.path.dirname(library_file_path)
     auxiliary_dir = os.path.relpath(auxiliary_dir, library_file_dir)
     imports_emitter = library_emitter.Emit(
         self._template, AUXILIARY_DIR=massage_path(auxiliary_dir))
     for path in sorted(self._path_to_emitter.keys()):
       relpath = os.path.relpath(path, library_file_dir)
       imports_emitter.Emit(
           "#source('$PATH');\n", PATH=massage_path(relpath))