Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1105453002: Revert of [strong] checking of this & super in constructors (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [strong] checking of this & super in constructors (patchset #7 id:110001 of https://codereview.chromium.org/1024063002/) Reason for revert: [Sheriff] Breaks mac gc stress: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1024 Original issue's description: > [strong] checking of this & super in constructors > > R=dslomov@chromium.org, marja@chromium.org > BUG=v8:3956 > LOG=N > > Enforces for constructors that > - the only use of 'super' is the super constructor call > - the only use of 'this' is a property assignment > - both of these must happen at the top-level of the body > - 'this' may only be assigned after the 'super' call > - 'return' may only be used after the last assignment to 'this' > > Not yet working for arrow functions (there might be deeper bugs with those). > > Committed: https://crrev.com/580d66bcda66220d2f3062ac58daf925436df74c > Cr-Commit-Position: refs/heads/master@{#27977} TBR=dslomov@chromium.org,marja@chromium.org,conradw@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 Committed: https://crrev.com/b3875aacbbf53ed7a743ce07526cce8c460ade40 Cr-Commit-Position: refs/heads/master@{#27991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -470 lines) Patch
M src/messages.js View 1 chunk +2 lines, -4 lines 0 comments Download
M src/parser.h View 3 chunks +7 lines, -4 lines 0 comments Download
M src/parser.cc View 8 chunks +29 lines, -62 lines 0 comments Download
M src/preparser.h View 13 chunks +27 lines, -167 lines 0 comments Download
M src/preparser.cc View 4 chunks +11 lines, -63 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +16 lines, -113 lines 0 comments Download
M test/mjsunit/strong/classes.js View 3 chunks +0 lines, -57 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of [strong] checking of this & super in constructors
5 years, 8 months ago (2015-04-22 08:00:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105453002/1
5 years, 8 months ago (2015-04-22 08:00:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 08:00:44 UTC) #3
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1073103004/ by machenbach@chromium.org. ...
5 years, 8 months ago (2015-04-22 11:04:17 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:19:03 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3875aacbbf53ed7a743ce07526cce8c460ade40
Cr-Commit-Position: refs/heads/master@{#27991}

Powered by Google App Engine
This is Rietveld 408576698