Add net_log events for the Data Reduction Proxy config service client.

Add net_log events for the Data Reduction Proxy config service client.

The start and completion of the config retrieval requests will be logged,
and made available to the chrome://net-internals/#bandwidth page.

BUG=466753
Committed: https://crrev.com/3074bf4dcf5b9a89ede7cba949f3e4ef606d40ac
Cr-Commit-Position: refs/heads/master@{#327389}

[jeremyim, 2015-04-22 23:20:24]

jeremyim@chromium.org changed reviewers:
+ bengr@chromium.org, mef@chromium.org

[jeremyim, 2015-04-22 23:20:24]

PTAL.

bengr => data_reduction_proxy*
mef => net_log_event_type_list.h

Thanks! =)

[jeremyim, 2015-04-23 00:04:03]

Patchset #1 (id:1) has been deleted

[bengr, 2015-04-27 22:49:42]

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
(right):

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc:109:
test_context_->io_data()->config(), test_context_->event_creator(),
Forward declare the event creator and net log.

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc
(right):

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc:128:
// A callback which creates a base::Value containing information about
nit: which -> that.

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc:247:
// This callback must be invoked synchronously
nit: period.

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc:317:
if (event.get()) {
Remove .get()

[jeremyim, 2015-04-28 00:04:25]

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
(right):

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc:109:
test_context_->io_data()->config(), test_context_->event_creator(),
On 2015/04/27 22:49:42, bengr wrote:
> Forward declare the event creator and net log.

The declarations shouldn't be necessary; they're already in
data_reduction_proxy_config_service_client.h

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc
(right):

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc:128:
// A callback which creates a base::Value containing information about
On 2015/04/27 22:49:42, bengr wrote:
> nit: which -> that.

Done.

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc:247:
// This callback must be invoked synchronously
On 2015/04/27 22:49:42, bengr wrote:
> nit: period.

Done.

https://codereview.chromium.org/1105443003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc:317:
if (event.get()) {
On 2015/04/27 22:49:42, bengr wrote:
> Remove .get()

Done.

[bengr, 2015-04-28 16:53:37]

lgtm

[jeremyim, 2015-04-28 20:02:07]

jeremyim@chromium.org changed reviewers:
+ eroman@chromium.org
- mef@chromium.org

[jeremyim, 2015-04-28 20:02:07]

eroman => Please take a look at net_log_event_type_list.h

Thanks!

[eroman, 2015-04-28 21:44:28]

net/log/* LGTM

[jeremyim, 2015-04-28 21:49:24]

Thank you for looking at this! =)

[jeremyim, 2015-04-28 21:49:27]

The CQ bit was checked by jeremyim@chromium.org

[commit-bot: I haz the power, 2015-04-28 21:50:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1105443003/60001

[commit-bot: I haz the power, 2015-04-28 23:29:36]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-04-28 23:30:36]

Patchset 3 (id:??) landed as
https://crrev.com/3074bf4dcf5b9a89ede7cba949f3e4ef606d40ac
Cr-Commit-Position: refs/heads/master@{#327389}