Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1105443002: go: update go build rules (Closed)

Created:
5 years, 8 months ago by rogulenko
Modified:
5 years, 8 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

go: update go build rules Replace go_shared_library with go_mojo_application that does the same + copies library to root_build_dir. It makes go applications more convenient to use. Updating README files with new instructions. Also changing go echo client to talk to go echo server. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/88023de282255d472436de08e8aadcccb7d09cdd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M examples/go/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/go/README.txt View 1 chunk +1 line, -6 lines 0 comments Download
M examples/go/echo_client.go View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/go/echo_server.go View 1 chunk +1 line, -1 line 0 comments Download
M mojo/go/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/go/rules.gni View 2 chunks +16 lines, -4 lines 0 comments Download
M mojo/go/sample_app/README.txt View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rogulenko
5 years, 8 months ago (2015-04-22 04:42:42 UTC) #2
jamesr
lgtm
5 years, 8 months ago (2015-04-22 05:21:51 UTC) #3
rogulenko
5 years, 8 months ago (2015-04-22 18:43:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
88023de282255d472436de08e8aadcccb7d09cdd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698