Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6435)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1105423003: Mac: Don't update prefs file unnecessarily when activating windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@perf.cpu_usage
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 0dc17f12ddebb38ae54e8f6ae38219fbc257c557..b176b641400a2f937443ab322da898476ab793bf 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -55,6 +55,7 @@
#import "chrome/browser/ui/cocoa/framed_browser_window.h"
#import "chrome/browser/ui/cocoa/fullscreen_window.h"
#import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h"
+#include "chrome/browser/ui/cocoa/last_active_browser_cocoa.h"
#import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h"
#import "chrome/browser/ui/cocoa/presentation_mode_controller.h"
#import "chrome/browser/ui/cocoa/profiles/avatar_base_controller.h"
@@ -590,8 +591,10 @@ using content::WebContents;
// Called right after our window became the main window.
- (void)windowDidBecomeMain:(NSNotification*)notification {
- BrowserList::SetLastActive(browser_.get());
- [self saveWindowPositionIfNeeded];
+ if (chrome::GetLastActiveBrowser() != browser_) {
+ BrowserList::SetLastActive(browser_.get());
+ [self saveWindowPositionIfNeeded];
+ }
[[[self window] contentView] cr_recursivelyInvokeBlock:^(id view) {
if ([view conformsToProtocol:@protocol(ThemedWindowDrawing)])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698