Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 1105423003: Mac: Don't update prefs file unnecessarily when activating windows. (Closed)

Created:
5 years, 7 months ago by Andre
Modified:
5 years, 7 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@perf.cpu_usage
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Don't update prefs file unnecessarily when activating windows. When activating Chrome app from another app, often times we are reactivating the same browser window. In this case, we don't need to update prefs with a new profile and window position. Avoiding prefs update is good because it triggers JSON file writing to disk (after a 10 seconds delay). BUG=482027 Committed: https://crrev.com/d47c029d28e6fa926ae2331b4a6b65ccca8b82a6 Cr-Commit-Position: refs/heads/master@{#327418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Andre
ccameron PTAL
5 years, 7 months ago (2015-04-28 20:16:51 UTC) #2
ccameron
lgtm
5 years, 7 months ago (2015-04-28 21:29:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105423003/1
5 years, 7 months ago (2015-04-28 23:46:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 02:13:06 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 02:13:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d47c029d28e6fa926ae2331b4a6b65ccca8b82a6
Cr-Commit-Position: refs/heads/master@{#327418}

Powered by Google App Engine
This is Rietveld 408576698