chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm - Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

index 1ee0f88b90cd9f61d0c7cbbbfb26390ef3a318bc..b46148e9d645f3505336a3d2eb0171b0280b7029 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

@@ -110,7 +110,7 @@ TEST_F(BookmarkMenuBridgeTest, TestBookmarkMenuAutoSeparator) {

EXPECT_EQ(6, [menu numberOfItems]);

// Remove the new bookmark and reload and we should have 2 items again

// because the separator should have been removed as well.

- model->Remove(parent, 0);

+ model->Remove(parent->GetChild(0));

bridge_->UpdateMenu(menu);

EXPECT_EQ(0, [menu numberOfItems]);

}

@@ -329,7 +329,7 @@ TEST_F(BookmarkMenuBridgeTest, TestGetMenuItemForNode) {

const BookmarkNode* removed_node = root->GetChild(0);

EXPECT_EQ(2, root->child_count());

- model->Remove(root, 0);

+ model->Remove(root->GetChild(0));

EXPECT_EQ(1, root->child_count());

bridge_->UpdateMenu(menu);

EXPECT_FALSE(MenuItemForNode(bridge_.get(), removed_node));