chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc - Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/provider/chrome_browser_provider.cc ('k') | chrome/browser/history/android/bookmark_model_sql_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

index 6c9fb4a731c01ed2b7b9eb2d25792bb637e7aa91..4e0fa043cdadc40959c5a6a818bd9b124cc40a58 100644

--- a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

+++ b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

@@ -136,8 +136,7 @@ bool RemoveNode(BookmarkModel* model,

return false;

}

- const BookmarkNode* parent = node->parent();

- model->Remove(parent, parent->GetIndexOf(node));

+ model->Remove(node);

return true;

}