Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1505)

Unified Diff: chrome/browser/android/bookmarks/bookmarks_bridge.cc

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/provider/chrome_browser_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/bookmarks/bookmarks_bridge.cc
diff --git a/chrome/browser/android/bookmarks/bookmarks_bridge.cc b/chrome/browser/android/bookmarks/bookmarks_bridge.cc
index b6e052b8093f20a99b352755cdcc28e75dc34c82..236d3a16bd908d108cda7e3e76a31d2e35591005 100644
--- a/chrome/browser/android/bookmarks/bookmarks_bridge.cc
+++ b/chrome/browser/android/bookmarks/bookmarks_bridge.cc
@@ -614,12 +614,10 @@ void BookmarksBridge::DeleteBookmark(JNIEnv* env,
return;
}
- if (partner_bookmarks_shim_->IsPartnerBookmark(node)) {
+ if (partner_bookmarks_shim_->IsPartnerBookmark(node))
partner_bookmarks_shim_->RemoveBookmark(node);
- } else {
- const BookmarkNode* parent_node = GetParentNode(node);
- bookmark_model_->Remove(parent_node, parent_node->GetIndexOf(node));
- }
+ else
+ bookmark_model_->Remove(node);
}
void BookmarksBridge::MoveBookmark(JNIEnv* env,
« no previous file with comments | « no previous file | chrome/browser/android/provider/chrome_browser_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698