components/undo/bookmark_undo_service.cc - Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/undo/bookmark_undo_service.cc

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/bookmarks/browser/bookmark_model.cc ('K') | « components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc ('k') | components/undo/bookmark_undo_service_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/undo/bookmark_undo_service.cc

diff --git a/components/undo/bookmark_undo_service.cc b/components/undo/bookmark_undo_service.cc

index 695bacb91a18d9ad354b81b53bf5ccf503c81639..21a34119ace45434643fc7134a78f74b42aa64c4 100644

--- a/components/undo/bookmark_undo_service.cc

+++ b/components/undo/bookmark_undo_service.cc

@@ -84,7 +84,7 @@ void BookmarkAddOperation::Undo() {

bookmarks::GetBookmarkNodeByID(model, parent_id_);

DCHECK(parent);

- model->Remove(parent, index_);

+ model->Remove(parent->GetChild(index_));

}

int BookmarkAddOperation::GetUndoLabelId() const {