Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: components/bookmarks/browser/bookmark_utils.cc

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_utils.cc
diff --git a/components/bookmarks/browser/bookmark_utils.cc b/components/bookmarks/browser/bookmark_utils.cc
index ccd5ebb5dd2340fe467d7fb49c8ec3a0e43505a0..59aa885d111859bb0727e850bdc7f50908ea9a23 100644
--- a/components/bookmarks/browser/bookmark_utils.cc
+++ b/components/bookmarks/browser/bookmark_utils.cc
@@ -204,7 +204,7 @@ void CopyToClipboard(BookmarkModel* model,
for (size_t i = 0; i < filtered_nodes.size(); ++i) {
int index = filtered_nodes[i]->parent()->GetIndexOf(filtered_nodes[i]);
if (index > -1)
- model->Remove(filtered_nodes[i]->parent(), index);
+ model->Remove(filtered_nodes[i]);
}
}
}
@@ -439,8 +439,7 @@ void DeleteBookmarkFolders(BookmarkModel* model,
const BookmarkNode* node = GetBookmarkNodeByID(model, *iter);
if (!node)
continue;
- const BookmarkNode* parent = node->parent();
- model->Remove(parent, parent->GetIndexOf(node));
+ model->Remove(node);
}
}
@@ -463,7 +462,7 @@ void RemoveAllBookmarks(BookmarkModel* model, const GURL& url) {
const BookmarkNode* node = bookmarks[i];
int index = node->parent()->GetIndexOf(node);
if (index > -1 && model->client()->CanBeEditedByUser(node))
- model->Remove(node->parent(), index);
+ model->Remove(node);
}
}

Powered by Google App Engine
This is Rietveld 408576698