Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.mm

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm » ('j') | components/bookmarks/browser/bookmark_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.mm
diff --git a/chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.mm b/chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.mm
index b0cacec7e14dc712f85526711daa436833213100..cc2e8b7ad79a0a826d119627fdd6be0995161372 100644
--- a/chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.mm
+++ b/chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.mm
@@ -86,7 +86,7 @@ using bookmarks::BookmarkNode;
if (!model)
return;
- model->Remove(bookmarkNode_, position);
+ model->Remove(bookmarkNode_->GetChild(position));
}
- (NSArray*)bookmarkItems {
@@ -173,7 +173,7 @@ using bookmarks::BookmarkNode;
if (!model)
return;
- model->Remove(bookmarkNode_, position);
+ model->Remove(bookmarkNode_->GetChild(position));
}
- (int)calculatePositionOfBookmarkFolderAt:(int)index {
« no previous file with comments | « chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm » ('j') | components/bookmarks/browser/bookmark_model.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698