chrome/browser/android/bookmarks/bookmarks_bridge.cc - Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/bookmarks/bookmarks_bridge.cc

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/bookmarks/bookmarks_bridge.cc

diff --git a/chrome/browser/android/bookmarks/bookmarks_bridge.cc b/chrome/browser/android/bookmarks/bookmarks_bridge.cc

index b6e052b8093f20a99b352755cdcc28e75dc34c82..2e0020b6913d2c693cdfb4f1293c93a4e0e19dca 100644

--- a/chrome/browser/android/bookmarks/bookmarks_bridge.cc

+++ b/chrome/browser/android/bookmarks/bookmarks_bridge.cc

@@ -618,7 +618,7 @@ void BookmarksBridge::DeleteBookmark(JNIEnv* env,

partner_bookmarks_shim_->RemoveBookmark(node);

} else {

const BookmarkNode* parent_node = GetParentNode(node);

- bookmark_model_->Remove(parent_node, parent_node->GetIndexOf(node));

+ bookmark_model_->Remove(parent_node, node);

}

« no previous file with comments | « no previous file | chrome/browser/android/provider/chrome_browser_provider.cc » ('j') | components/bookmarks/browser/bookmark_model.h » ('J')