chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm - Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import <Cocoa/Cocoa.h>	5 #import <Cocoa/Cocoa.h>

6	6

7 #include "base/memory/scoped_ptr.h"	7 #include "base/memory/scoped_ptr.h"

8 #include "base/strings/utf_string_conversions.h"	8 #include "base/strings/utf_string_conversions.h"

9 #include "chrome/browser/bookmarks/bookmark_model_factory.h"	9 #include "chrome/browser/bookmarks/bookmark_model_factory.h"

10 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h"	10 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h"

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 EXPECT_EQ(0U, deletions);	49 EXPECT_EQ(0U, deletions);

50	50

51 model->SetURL(node, GURL("http://www.google.com/reader"));	51 model->SetURL(node, GURL("http://www.google.com/reader"));

52 EXPECT_EQ(2U, pings);	52 EXPECT_EQ(2U, pings);

53 EXPECT_EQ(0U, deletions);	53 EXPECT_EQ(0U, deletions);

54	54

55 model->Move(node, model->other_node(), 0);	55 model->Move(node, model->other_node(), 0);

56 EXPECT_EQ(3U, pings);	56 EXPECT_EQ(3U, pings);

57 EXPECT_EQ(0U, deletions);	57 EXPECT_EQ(0U, deletions);

58	58

59 model->Remove(node->parent(), 0);	59 model->Remove(node->parent()->GetChild(0));

60 EXPECT_EQ(4U, pings);	60 EXPECT_EQ(4U, pings);

61 EXPECT_EQ(1U, deletions);	61 EXPECT_EQ(1U, deletions);

62 }	62 }

63	63

64 } // namespace	64 } // namespace

OLD	NEW