Avoid conversion of index to BookmarkNode pointer unnacessarily.

chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <AppKit/AppKit.h>
 
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 92 matching lines @@
   // Add a bookmark and reload and there should be 8 items: the previous
   // menu contents plus two new separator, the new bookmark and three
   // versions of 'Open All Bookmarks' menu items.
   const BookmarkNode* parent = model->bookmark_bar_node();
   const char* url = "http://www.zim-bop-a-dee.com/";
   model->AddURL(parent, 0, ASCIIToUTF16("Bookmark"), GURL(url));
   bridge_->UpdateMenu(menu);
   EXPECT_EQ(6, [menu numberOfItems]);
   // Remove the new bookmark and reload and we should have 2 items again
   // because the separator should have been removed as well.
-  model->Remove(parent, 0);
+  model->Remove(parent, parent->GetChild(0));
   bridge_->UpdateMenu(menu);
   EXPECT_EQ(0, [menu numberOfItems]);
 }
 
 // Test that ClearBookmarkMenu() removes all bookmark menus.
 TEST_F(BookmarkMenuBridgeTest, TestClearBookmarkMenu) {
   NSMenu* menu = bridge_->menu_;
 
   AddTestMenuItem(menu, @"hi mom", nil);
   AddTestMenuItem(menu, @"not", @selector(openBookmarkMenuItem:));
@@ skipping 198 matching lines @@
   AddNodeToMenu(bridge_.get(), root, menu);
   EXPECT_TRUE(MenuItemForNode(bridge_.get(), root->GetChild(0)));
 
   model->AddURL(root, 1, ASCIIToUTF16("Test 2"), GURL("http://second-test"));
   AddNodeToMenu(bridge_.get(), root, menu);
   EXPECT_TRUE(MenuItemForNode(bridge_.get(), root->GetChild(0)));
   EXPECT_TRUE(MenuItemForNode(bridge_.get(), root->GetChild(1)));
 
   const BookmarkNode* removed_node = root->GetChild(0);
   EXPECT_EQ(2, root->child_count());
-  model->Remove(root, 0);
+  model->Remove(root, root->GetChild(0));
   EXPECT_EQ(1, root->child_count());
   bridge_->UpdateMenu(menu);
   EXPECT_FALSE(MenuItemForNode(bridge_.get(), removed_node));
   EXPECT_TRUE(MenuItemForNode(bridge_.get(), root->GetChild(0)));
 
   const BookmarkNode empty_node(GURL("http://no-where/"));
   EXPECT_FALSE(MenuItemForNode(bridge_.get(), &empty_node));
   EXPECT_FALSE(MenuItemForNode(bridge_.get(), NULL));
 }
 
@@ skipping 49 matching lines @@
   EXPECT_TRUE([item image]);
 
   model->SetTitle(node, ASCIIToUTF16("New Title"));
 
   item = [menu itemWithTitle:@"Test Item"];
   EXPECT_FALSE(item);
   item = [menu itemWithTitle:@"New Title"];
   EXPECT_TRUE(item);
 }