Add a test for checking objects reported by DevTools memory instrumentation not allocated by tcmall…

chrome/test/pyautolib/remote_inspector_client.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Chrome remote inspector utility for pyauto tests.
 
 This script provides a python interface that acts as a front-end for Chrome's
 remote inspector module, communicating via sockets to interact with Chrome in
 the same way that the Developer Tools does.  This -- in theory -- should allow
@@ skipping 693 matching lines @@
 class NativeMemorySnapshot(object):
   """Class representing native memory snapshot captured by Chromium DevTools.
 
   It is just a convenient wrapper around the snapshot structure returned over
   the remote debugging protocol. The raw snapshot structure is defined in
   WebKit/Source/WebCore/inspector/Inspector.json
 
   Public Methods:
     GetProcessPrivateMemorySize: The process total size.
     GetUnknownSize: Size of not instrumented parts.
     FindMemoryBlock: Given an array of memory block names return the block.

[dennis_jeffrey, 2012/10/04 01:16:33]

Add the two new public methods to the docstring here.

[yurys, 2012/10/04 15:07:47]

Done.

   """
   def __init__(self, root_block):
     self._root = root_block
 
   def GetProcessPrivateMemorySize(self):
     return self._root['size']
 
   def GetUnknownSize(self):
     """Size of the memory whose owner is unknown to DevTools."""
     known_size = 0
     for child in self._root['children']:
       known_size += child['size']
     return self.GetProcessPrivateMemorySize() - known_size
 
+  def GetInstrumentedObjectsCount(self):

[dennis_jeffrey, 2012/10/04 01:16:33]

add a docstring and mention what is returned if the value isn't found.

[yurys, 2012/10/04 15:07:47]

Done.

+    memory_block = self.FindMemoryBlock(['ProcessPrivateMemory',
+        'InstrumentedObjectsCount'])
+    if not memory_block is None:
+      return memory_block['size']
+    return -1

[dennis_jeffrey, 2012/10/04 01:16:33]

would returning None be preferable to a -1?  That way we can check for a
successful return type with the "not" operator.

[yurys, 2012/10/04 15:07:47]

Good idea, fixed!

+
+  def GetNumberOfInstrumentedObjectsNotInHeap(self):

[dennis_jeffrey, 2012/10/04 01:16:33]

add a docstring and mention what is returned if the value isn't found.

[yurys, 2012/10/04 15:07:47]

Done.

+    memory_block = self.FindMemoryBlock(['ProcessPrivateMemory',
+        'InstrumentedButNotAllocatedObjectsCount'])
+    if not memory_block is None:
+      return memory_block['size']
+    return -1

[dennis_jeffrey, 2012/10/04 01:16:33]

same comment as line 734 above

[yurys, 2012/10/04 15:07:47]

Done.

+
   def FindMemoryBlock(self, path):
     """Find memory block with given path.
 
     Args:
       path: Array of block names, first element is the root block
             name, last one is the name of the block to find.
 
     Returns:
       Memory block with given path or None.
     """
@@ skipping 413 matching lines @@
 
     Returns:
       A human-readable string representation of the given number of bytes.
     """
     if num_bytes < 1024:
       return '%d B' % num_bytes
     elif num_bytes < 1048576:
       return '%.2f KB' % (num_bytes / 1024.0)
     else:
       return '%.2f MB' % (num_bytes / 1048576.0)