Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1105383004: Fix prober latency calculation. (Closed)

Created:
5 years, 7 months ago by jcgregorio
Modified:
5 years, 7 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix prober latency calculation. Math is hard. TBR=borenet BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/aab3c9b6ebde0a4e1a3c18a259678a7325398975

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M prober/go/prober/main.go View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 7 (2 generated)
jcgregorio
5 years, 7 months ago (2015-04-29 19:13:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105383004/1
5 years, 7 months ago (2015-04-29 19:14:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/buildbot/+/aab3c9b6ebde0a4e1a3c18a259678a7325398975
5 years, 7 months ago (2015-04-29 19:15:37 UTC) #5
borenet
:) LGTM https://codereview.chromium.org/1105383004/diff/1/prober/go/prober/main.go File prober/go/prober/main.go (right): https://codereview.chromium.org/1105383004/diff/1/prober/go/prober/main.go#newcode278 prober/go/prober/main.go:278: probe.latency.Update(d.Nanoseconds() / (1000 * 1000)) Again, this ...
5 years, 7 months ago (2015-04-29 19:15:57 UTC) #6
jcgregorio
5 years, 7 months ago (2015-04-29 19:21:10 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1105383004/diff/1/prober/go/prober/main.go
File prober/go/prober/main.go (right):

https://codereview.chromium.org/1105383004/diff/1/prober/go/prober/main.go#ne...
prober/go/prober/main.go:278: probe.latency.Update(d.Nanoseconds() / (1000 *
1000))
On 2015/04/29 19:15:56, borenet wrote:
> Again, this could be rewritten as (d.Nanoseconds() / time.Millisecond) which
> would be a little clearer.

Fixed in next CL.

Powered by Google App Engine
This is Rietveld 408576698