Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: src/compiler/source-position.h

Issue 1105363003: [turbofan] Don't spread global flag checks all over the compiler code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/simplified-lowering.cc ('k') | src/compiler/source-position.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/source-position.h
diff --git a/src/compiler/source-position.h b/src/compiler/source-position.h
index 68c4b4eadf30dbc1fa937ba2e9b0a25de44b7456..3033f74d173256d668dbdd351b460b932067de8d 100644
--- a/src/compiler/source-position.h
+++ b/src/compiler/source-position.h
@@ -45,7 +45,7 @@ inline bool operator!=(const SourcePosition& lhs, const SourcePosition& rhs) {
class SourcePositionTable final {
public:
- class Scope {
+ class Scope final {
public:
Scope(SourcePositionTable* source_positions, SourcePosition position)
: source_positions_(source_positions),
@@ -66,14 +66,14 @@ class SourcePositionTable final {
}
}
- SourcePositionTable* source_positions_;
- SourcePosition prev_position_;
+ SourcePositionTable* const source_positions_;
+ SourcePosition const prev_position_;
DISALLOW_COPY_AND_ASSIGN(Scope);
};
explicit SourcePositionTable(Graph* graph);
~SourcePositionTable() {
- if (decorator_ != NULL) RemoveDecorator();
+ if (decorator_) RemoveDecorator();
}
void AddDecorator();
@@ -86,7 +86,7 @@ class SourcePositionTable final {
private:
class Decorator;
- Graph* graph_;
+ Graph* const graph_;
Decorator* decorator_;
SourcePosition current_position_;
NodeAuxData<SourcePosition> table_;
@@ -98,4 +98,4 @@ class SourcePositionTable final {
} // namespace internal
} // namespace v8
-#endif
+#endif // V8_COMPILER_SOURCE_POSITION_H_
« no previous file with comments | « src/compiler/simplified-lowering.cc ('k') | src/compiler/source-position.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698