Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1105333003: Fix potential flakiness in Files.app test (Closed)

Created:
5 years, 7 months ago by yoshiki
Modified:
5 years, 7 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix potential flakiness in Files.app test This patch makes the banner & focus code robust with promise. And make sure the banner existences before test runs. BUG=478640 TEST=run TabindexFocusDownloads/FileManagerBrowserTest.Test/0 100 times Committed: https://crrev.com/47464b35a33c06fa664c4f3e009a2d732fda1c1e Cr-Commit-Position: refs/heads/master@{#327255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -105 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 2 chunks +14 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/banners.js View 3 chunks +98 lines, -89 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js View 1 chunk +15 lines, -14 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/tab_index.js View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
Fukino-san, PTAL. Thanks.
5 years, 7 months ago (2015-04-28 08:17:51 UTC) #2
fukino
On 2015/04/28 08:17:51, yoshiki wrote: > Fukino-san, PTAL. Thanks. LGTM!
5 years, 7 months ago (2015-04-28 09:29:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105333003/1
5 years, 7 months ago (2015-04-28 09:33:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 09:58:28 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 09:59:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47464b35a33c06fa664c4f3e009a2d732fda1c1e
Cr-Commit-Position: refs/heads/master@{#327255}

Powered by Google App Engine
This is Rietveld 408576698