Issue 110533004: CHR-1706: Context menu with Shift+F10 shows out of Opera when web contents scrolled

Issue 110533004: CHR-1706: Context menu with Shift+F10 shows out of Opera when web contents scrolled (Closed)

Created:
7 years ago by Mikus

Modified:
6 years, 9 months ago

Reviewers:
bokan, arv (Not doing code reviews), Zeeshan Qureshi, eseidel

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

CHR-1706: Context menu with Shift+F10 shows out of Opera when web contents scrolled. In case we are opening a context menu on an element, the menu should be shown as currently, since the element has most probably a correct transform available. Since the <body> element possibly has contents of great height, the context menu should be shown on the upper edge of the displayed part of the element. BUG=Context menu with Shift+F10 shows out of Opera when web contents scrolled. The menu's position should not be translated by scroll position in case of opening a menu for the <body> element. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169956

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	Source/core/page/EventHandler.cpp	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

bokan

Hi Mikus, This should have a test. Nit: Wrap the issue description at 80 cols. ...

7 years ago (2013-12-18 19:49:07 UTC) #1

Mikus

Please review this changeset. Looks like the context menu is shown out of browser if ...

7 years ago (2013-12-19 10:47:43 UTC) #2

Mikus

On 2013/12/19 10:47:43, Mikus wrote: > Please review this changeset. Looks like the context menu ...

7 years ago (2013-12-19 10:49:00 UTC) #3

Mikus

On 2013/12/19 10:49:00, Mikus wrote: > On 2013/12/19 10:47:43, Mikus wrote: > > Please review ...

6 years, 11 months ago (2014-01-08 08:22:01 UTC) #4

arv (Not doing code reviews)

The changes look OK to me but I wish you could expand a bit on ...

6 years, 9 months ago (2014-03-13 15:06:27 UTC) #5

Mikus

On 2014/03/13 15:06:27, arv wrote: > The changes look OK to me but I wish ...

6 years, 9 months ago (2014-03-24 14:31:34 UTC) #6

arv (Not doing code reviews)

I don't understand what "CHR-1706" is used for? Is there a cr bug for this ...

6 years, 9 months ago (2014-03-24 14:52:19 UTC) #7

Mikus

On 2014/03/24 14:52:19, arv wrote: > I don't understand what "CHR-1706" is used for? > ...

6 years, 9 months ago (2014-03-24 14:56:56 UTC) #8

arv (Not doing code reviews)

On 2014/03/24 14:56:56, Mikus wrote: > On 2014/03/24 14:52:19, arv wrote: > > I don't ...

6 years, 9 months ago (2014-03-24 15:05:21 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mboc@opera.com/110533004/1

6 years, 9 months ago (2014-03-25 15:23:26 UTC) #12

Message was sent while issue was closed.

Change committed as 169956

Expand Messages | Collapse Messages