Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: lib/html/scripts/systemhtml.py

Issue 11053016: Remove constants declaration from dart2js implementation classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/dart2js/html_dart2js.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/systemhtml.py
diff --git a/lib/html/scripts/systemhtml.py b/lib/html/scripts/systemhtml.py
index 7ff873a0a833d86d5024070081003bdf64cc4612..3592437e529d5784f51612089edfe0c4c643c153 100644
--- a/lib/html/scripts/systemhtml.py
+++ b/lib/html/scripts/systemhtml.py
@@ -427,7 +427,6 @@ class HtmlDartInterfaceGenerator(BaseGenerator):
NAME=constant.id,
TYPE=type,
VALUE=constant.value)
- self._backend.AddConstant(constant)
def _EmitEventGetter(self, events_interface, events_class):
self._members_emitter.Emit(
@@ -539,15 +538,6 @@ class Dart2JSBackend(BaseGenerator):
def FinishInterface(self):
pass
- def AddConstant(self, constant):
- # Since we are currently generating native classes without interfaces,
- # generate the constants as part of the class. This will need to go away
- # if we revert back to generating interfaces.
- self._members_emitter.Emit('\n static const $TYPE $NAME = $VALUE;\n',
- NAME=constant.id,
- TYPE=self._DartType(constant.type.id),
- VALUE=constant.value)
-
def EmitFactoryProvider(self, constructor_info, factory_provider, emitter):
template_file = ('factoryprovider_%s.darttemplate' %
self._html_interface_name)
« no previous file with comments | « lib/html/dart2js/html_dart2js.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698