Issue 11053007: Make content shell support some testing flags.

Issue 11053007: Make content shell support some testing flags. (Closed)

Created:
8 years, 2 months ago by tonyg

Modified:
8 years, 2 months ago

Reviewers:
szym, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make content shell support some testing flags. This copies support for --testing-fixed-http-port, --testing-fixed-https-port and --host-resolver-rules from chrome to content_shell. These flags are useful for benchmarking against recorded web pages with web page replay. TEST=Manual BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159930

Patch Set 1 #

Total comments: 5

Patch Set 2 : Remove switch from chrome_switches.h and add CONTENT_EXPORT #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -10 lines)			Patch
M	chrome/common/chrome_switches.h	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/public/common/content_switches.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	content/shell/shell_url_request_context_getter.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/shell/shell_url_request_context_getter.cc	View		3 chunks	+24 lines, -0 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jam

https://codereview.chromium.org/11053007/diff/1/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): https://codereview.chromium.org/11053007/diff/1/chrome/common/chrome_switches.h#newcode207 chrome/common/chrome_switches.h:207: extern const char kHostResolverRules[]; nit: remove as well? https://codereview.chromium.org/11053007/diff/1/chrome/common/chrome_switches.h#newcode207 ...

8 years, 2 months ago (2012-10-03 16:08:12 UTC) #2

tonyg

http://codereview.chromium.org/11053007/diff/1/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): http://codereview.chromium.org/11053007/diff/1/chrome/common/chrome_switches.h#newcode207 chrome/common/chrome_switches.h:207: extern const char kHostResolverRules[]; On 2012/10/03 16:08:12, John Abd-El-Malek ...

8 years, 2 months ago (2012-10-03 16:26:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/11053007/5001

8 years, 2 months ago (2012-10-03 16:34:00 UTC) #5

szym

8 years, 2 months ago (2012-10-10 17:21:03 UTC) #7

https://chromiumcodereview.appspot.com/11053007/diff/5001/content/shell/shell...
File content/shell/shell_url_request_context_getter.cc (right):

https://chromiumcodereview.appspot.com/11053007/diff/5001/content/shell/shell...
content/shell/shell_url_request_context_getter.cc:133: new
net::MappedHostResolver(network_session_params.host_resolver));
IMPORTANT: this will cause double-free!
The MappedHostResolver takes ownership of the host_resolver but it's already
owned by storage_.

This was caught by: http://codereview.chromium.org/10831277/

Expand Messages | Collapse Messages