Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: src/heap/heap.cc

Issue 1105293004: Add mode to reduce memory usage in idle notification. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 8d34738dae81757b9e5918875d6adf41cecf98bb..266c3b1ab2094497233b263049a4333fe9717ebe 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -907,6 +907,13 @@ bool Heap::CollectGarbage(GarbageCollector collector, const char* gc_reason,
if (collector == MARK_COMPACTOR && FLAG_track_detached_contexts) {
isolate()->CheckDetachedContextsAfterGC();
}
+
+ if (collector == MARK_COMPACTOR) {
+ gc_idle_time_handler_.NotifyMarkCompact();
+ } else {
+ gc_idle_time_handler_.NotifyScavenge();
+ }
+
tracer()->Stop(collector);
}
@@ -1634,8 +1641,6 @@ void Heap::Scavenge() {
LOG(isolate_, ResourceEvent("scavenge", "end"));
gc_state_ = NOT_IN_GC;
-
- gc_idle_time_handler_.NotifyScavenge();
}
@@ -4562,6 +4567,7 @@ bool Heap::TryFinalizeIdleIncrementalMarking(
static_cast<size_t>(idle_time_in_ms), size_of_objects,
final_incremental_mark_compact_speed_in_bytes_per_ms))) {
CollectAllGarbage(kNoGCFlags, "idle notification: finalize incremental");
+ gc_idle_time_handler_.NotifyIdleMarkCompact();
ReduceNewSpaceSize(is_long_idle_notification);
return true;
}
@@ -4642,6 +4648,7 @@ bool Heap::IdleNotification(double deadline_in_seconds) {
break;
case DO_INCREMENTAL_MARKING: {
if (incremental_marking()->IsStopped()) {
+ // TODO(ulan): take reduce_memory into account.
incremental_marking()->Start();
}
double remaining_idle_time_in_ms = 0.0;

Powered by Google App Engine
This is Rietveld 408576698